Re: multi-input quirk and skip output reports quirk

[Anssi Hannula <anssi.hannula@gmail.com>]

Jiri Kosina wrote:
> On Tue, 1 Apr 2008, Anssi Hannula wrote:
> 
>> I've encountered another multi-input device that needs the skip output 
>> reports quirk (as it contains force feedback output reports), 0925:8866.
>> However, maybe we should use another approach, dropping
>> HID_QUIRK_SKIP_OUTPUT_REPORTS. Why not just *not* register the input
>> device for that report in case the report didn't contain anything that
>> was mapped by hidinput_configure_usage(), in hidinput_connect()?
> 
> Oh, and I seem to have completely forgotten -- is this quirk needed at 
> all? Since commit 82eb12198 we ignore the non-LED output reports in 
> hidinput_configure_usages() altogether.
> 
> Do you still actually see issues of devices being misconfigured due to 
> output reports confusion in hidinput_configure_usage() even in kernels 
> having this commit included?

Yes.

The point was that hidinput_connect() doesn't care whether all reports
were ignored by hidinput_configure_usage() or not.

-- 
Anssi Hannula