From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 2/8] [NETFILTER]: Use bool type in struct nf_conntrack_l3proto Date: Sun, 06 Apr 2008 17:22:14 +0200 Message-ID: <47F8EAA6.1040406@trash.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:36923 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbYDFPWI (ORCPT ); Sun, 6 Apr 2008 11:22:08 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > commit bb84a3dab22636fbf691b913a4ceff836c21ffb4 > Author: Jan Engelhardt > Date: Sat Mar 8 15:16:53 2008 +0100 > > [NETFILTER]: Use bool type in struct nf_conntrack_l3proto > > Signed-off-by: Jan Engelhardt > - int (*pkt_to_tuple)(const struct sk_buff *skb, unsigned int nhoff, > - struct nf_conntrack_tuple *tuple); > + bool (*pkt_to_tuple)(const struct sk_buff *skb, unsigned int nhoff, > + struct nf_conntrack_tuple *tuple); > This doesn't apply because of whitespace damage: * Try to fill in the third arg: nhoff is offset of l3 proto * hdr. Return true if possible. ^^^^^^^^^^ spaces that are not present in the tree I even tried the files taken from Maildir/, so its not mailer related. Besides that it *still* uses spaced for indentation. I didn't mean you should run it through your own checkpatch.pl version that doesn't complain about whitespace but through the one contained in the kernel tree.