From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 2/8] [NETFILTER]: Use bool type in struct nf_conntrack_l3proto Date: Sun, 06 Apr 2008 18:18:54 +0200 Message-ID: <47F8F7EE.7010009@trash.net> References: <47F8EAA6.1040406@trash.net> <47F8F39B.8060003@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Netfilter Developer Mailing List To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:38295 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbYDFQSq (ORCPT ); Sun, 6 Apr 2008 12:18:46 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > > On Sunday 2008-04-06 18:00, Patrick McHardy wrote: >> >>> hmkay? What you are seeing is that the offending line uses 8(+4) spaces >>> instead of a tab. >> >> I'm aware of that, so please fix your setup not to break >> whitespace. > > Blame me for missing out checkpatch alright, but don't say I touched > that line or broke the tab into 12 spaces there, because that just is > not the case. I didn't, I'm saying the patches you've sent me are broken. The reason is probably "format=flawed", but thats up to you to figure out.