From: Anthony Liguori <aliguori@us.ibm.com>
To: Paul Brook <paul@codesourcery.com>
Cc: Marcelo Tosatti <marcelo@kvack.org>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2)
Date: Mon, 07 Apr 2008 08:22:23 -0500 [thread overview]
Message-ID: <47FA200F.8080106@us.ibm.com> (raw)
In-Reply-To: <200804062241.08188.paul@codesourcery.com>
Paul Brook wrote:
> On Friday 04 April 2008 23:02:50 Anthony Liguori wrote:
>
>> uint32_t is the wrong type to use to represent physical addresses.
>> ....
>> /* XXX: temporary until new memory mapping API */
>> -uint32_t cpu_get_physical_page_desc(target_phys_addr_t addr)
>> +ram_addr_t cpu_get_physical_page_desc(target_phys_addr_t addr)
>>
>
> The returned value is still a uint32_t. Changing the function prototype
> without fixing that is just deluding yourself.
>
It's a ram_addr_t in KVM and the large mem patch I posted long ago
changes it to a ram_addr_t. But you're right, it doesn't belong in this
series.
Regards,
Anhtony Liguori
> Paul
>
prev parent reply other threads:[~2008-04-07 13:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 4:02 [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2) Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] " Anthony Liguori
2008-04-05 4:02 ` [PATCH 2/6] PCI DMA API (v2) Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] " Anthony Liguori
2008-04-05 4:02 ` [PATCH 3/6] virtio for QEMU (v2) Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] " Anthony Liguori
2008-04-05 4:02 ` [PATCH 4/6] virtio network driver (v2) Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] " Anthony Liguori
2008-04-05 4:02 ` [PATCH 5/6] virtio block " Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] " Anthony Liguori
2008-04-05 4:02 ` [PATCH 6/6] virtio balloon " Anthony Liguori
2008-04-05 4:02 ` [Qemu-devel] " Anthony Liguori
2008-04-06 6:57 ` [Qemu-devel] [PATCH 2/6] PCI DMA API (v2) Blue Swirl
2008-04-06 6:57 ` Blue Swirl
2008-04-06 15:22 ` Anthony Liguori
2008-04-06 15:22 ` [kvm-devel] " Anthony Liguori
2008-04-06 17:01 ` andrzej zaborowski
2008-04-06 17:01 ` [kvm-devel] " andrzej zaborowski
2008-04-06 17:46 ` Anthony Liguori
2008-04-06 17:46 ` [kvm-devel] " Anthony Liguori
2008-04-07 0:40 ` Paul Brook
2008-04-07 0:40 ` [kvm-devel] " Paul Brook
2008-04-07 8:32 ` andrzej zaborowski
2008-04-07 8:32 ` [kvm-devel] " andrzej zaborowski
2008-04-07 15:44 ` Paul Brook
2008-04-07 15:44 ` [Qemu-devel] " Paul Brook
2008-04-07 3:41 ` [Qemu-devel] [PATCH 1/6] Use ram_addr_t for cpu_get_physical_page_desc (v2) Paul Brook
2008-04-07 13:22 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FA200F.8080106@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=marcelo@kvack.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.