From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156]) by ozlabs.org (Postfix) with ESMTP id 58DAFDDF70 for ; Tue, 8 Apr 2008 08:31:09 +1000 (EST) Received: by fg-out-1718.google.com with SMTP id 16so1256308fgg.39 for ; Mon, 07 Apr 2008 15:31:07 -0700 (PDT) Message-ID: <47FAA0A8.7050602@genesi-usa.com> Date: Mon, 07 Apr 2008 23:31:04 +0100 From: Matt Sealey MIME-Version: 1.0 To: Grant Likely Subject: Re: Question on mpc52xx_common.c References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: Matt Sealey Cc: linuxppc-dev , Detlev Zundel List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Grant Likely wrote: > (cc'ing the mailing list in my reply) > > On Thu, Apr 3, 2008 at 10:27 AM, Detlev Zundel wrote: >> I wrote, >> >> > debugging a lite5200b kernel (linux-2.6-denx equivalent of 2.6.25-rc8) I >> > noticed that in mpc52xx_map_common_devices (mpc52xx_common.c:161) the >> > cdm module is tentatively mapped. It seems strange to me that there is no >> > error checking here. Is a FDT without an cdm entry usable at all? > > Sure, why not? If the firmware has already set it up correctly and no > devices using it are in use, then the kernel should be okay. :-) > That said, I can't imagine choosing to not put the cdm node into the > device tree. *ahem* Efika. -- Matt Sealey Genesi, Manager, Developer Relations