From: Pavel Emelyanov <xemul@openvz.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>,
Eric Dumazet <dada1@cosmosbay.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Stephen Hemminger <shemminger@vyatta.com>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH net-2.6.26 1/2] Shrink size of net_device by filling alignment holes in it.
Date: Tue, 08 Apr 2008 12:41:18 +0400 [thread overview]
Message-ID: <47FB2FAE.3080008@openvz.org> (raw)
In-Reply-To: <20080407174745.GE15681@ghostprotocols.net>
Ok, here are the results (summary):
i386, no patch, L1_CACHE_SHIFT=6:
/* size: 1024, cachelines: 16 */
/* sum members: 897, holes: 5, sum holes: 115 */
/* padding: 12 */
i386, no patch, L1_CACHE_SHIFT=7:
/* size: 1280, cachelines: 20 */
/* sum members: 897, holes: 5, sum holes: 307 */
/* padding: 76 */
i386, with patch, L1_CACHE_SHIFT=6:
/* size: 960, cachelines: 15 */
/* sum members: 897, holes: 4, sum holes: 47 */
/* padding: 16 */
i386, with patch, L1_CACHE_SHIFT=7:
/* size: 1024, cachelines: 16 */
/* sum members: 897, holes: 4, sum holes: 111 */
/* padding: 16 */
x86_64, no patch, L1_CACHE_SHIFT=7:
/* size: 1792, cachelines: 28 */
/* sum members: 1589, holes: 13, sum holes: 155 */
/* padding: 48 */
/* paddings: 1, sum paddings: 4 */
x86_64, with patch, L1_CACHE_SHIFT=7:
/* size: 1920, cachelines: 30 */
/* sum members: 1589, holes: 13, sum holes: 275 */
/* padding: 56 */
/* paddings: 1, sum paddings: 4 */
The +128 bytes on x86_64 is due to enlarged hole before
the refcnt field :(
So, on the i386 the structure shrinks, but on x86_64 - grows, but
on i386 it can be allocated from a twice smaller cache, while on
x86_64 nothing changes - it still fits the size-2048.
BTW, L1_CACHE_SHIFT=7 is set by default for distributions such as
rhel5, suse10 and fedora8...
So, does it worth trying to push them to Dave? :)
Thanks,
Pavel
next prev parent reply other threads:[~2008-04-08 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 16:25 [PATCH net-2.6.26 1/2] Shrink size of net_device by filling alignment holes in it Pavel Emelyanov
2008-04-07 17:04 ` Eric Dumazet
2008-04-07 17:17 ` Eric Dumazet
2008-04-07 17:47 ` Arnaldo Carvalho de Melo
2008-04-08 8:41 ` Pavel Emelyanov [this message]
2008-04-16 9:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FB2FAE.3080008@openvz.org \
--to=xemul@openvz.org \
--cc=acme@redhat.com \
--cc=dada1@cosmosbay.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.