All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: 0/8 Netfilter patches (group 2)
Date: Tue, 08 Apr 2008 18:23:00 +0200	[thread overview]
Message-ID: <47FB9BE4.5060209@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0804081814580.2229@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Tuesday 2008-04-08 18:14, Patrick McHardy wrote:
>> Small suggestion for improvement (don't worry, your series
>> is fine :)): the best ordering for all these patches would
>> have been:
>>
>> Set 1: boolean conversions
>> Set 2: length match (shouldn't have dependencies)
>> Set 3: recent match (also shouldn't have dependencies)
>> Set 4: prefix table
>> Set 5: TCPMSS target
>> Set 6: ARP-tables patches
> 
> You would not believe it, but it was set-ordered.
> YMMV what makes up a set, though.
> 
> [...]
> Invent house numbering?
> 
>  [patch 12/xx] xt_length
>  [patch 12a/xx] xt_length userspace
>  [patch 13/xx] xt_foobar (kernel only thing)
>  [patch 14/xx] xt_bazzzz
>  [patch 14a/xx] ..
> 
> don't think git likes that :p

:)

Just sending them seperately makes the barriers explicit,
so that makes most sense IMO.

      reply	other threads:[~2008-04-08 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08 16:08 0/8 Netfilter patches (group 2) Jan Engelhardt
2008-04-08 16:14 ` Patrick McHardy
2008-04-08 16:21   ` Jan Engelhardt
2008-04-08 16:23     ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FB9BE4.5060209@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@computergmbh.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.