Re: [Ebtables-devel] [PATCH 2/2] Add IPv6 support

[Patrick McHardy <kaber@trash.net>]

Tseng, Kuo-Lang wrote:
> Tseng, Kuo-Lang wrote on Monday, February 18, 2008 6:05 PM:
> 
>> This is the corresponding br-netfilter patch.
>>
>> It implements matching functions for IPv6 address & traffic class
>> (merged from the patch sent by Jan Engelhardt
>> [jengelh@computergmbh.de]
>> http://marc.info/?l=netfilter-devel&m=120182168424052&w=2), protocol,
>> and layer-4 port id. Corresponding watcher logging function is also
>> added for IPv6. 
>>
>> Signed-off-by: Kuo-lang Tseng <kuo-lang.tseng@intel.com>
> 
> Reposting the patch as an attachment (earlier one had line split. Sorry
> about that)


I wanted to apply this, but the patch has multiple checkpatch
errors. There are also some codingstyle errors checkpatch doesn't
complain about, like:

+       for (i = 0; i < 4; i++)
+          tmp_addr.in6_u.u6_addr32[i] = ih6->saddr.in6_u.u6_addr32[i] &
         ^^^ needs tab

It also seems the TCP/UDP/.. logging part could be shared between
IPv4 and IPv6. The protocol checks seem to be missing UDPLITE.

Please fix those up and resend, thanks.