Re: 2.6.25-rc8 regression with openswan

[Patrick McHardy <kaber@trash.net>]

Patrick McHardy wrote:
> The problem appears to be that openswan doesn't initialize the
> selectors family when adding new SAs. xfrm_init_state() uses
> the family to decide whether to set up inter family SAs or
> regular SAs. We used to fix up the family in xfrm_user, but
> this is now only done for transport mode SAs.
>
> -       /*
> -        * Set inner address family if the KM left it as zero.
> -        * See comment in validate_tmpl.
> -        */
> -       if (!x->sel.family)
> +       if (x->props.mode == XFRM_MODE_TRANSPORT)
>                 x->sel.family = p->family;
> +
>
> Reverting this part should fix it, but would break inter family
> tunnels again. It seems we need a different indication for
> xfrm_init_state() for inter family SAs.
>
> Kazunori, any ideas?


Did you have a chance to look into this? This is most likely
going to break a lot of setups, so a fix is really needed
before 2.6.25 is released.