Aurelien Jarno schrieb: > On Wed, Apr 02, 2008 at 07:40:24PM +0200, Kevin Wolf wrote: >> There are few helper functions (e.g. qemu_malloc) in osdep.c which are >> not OS dependent at all. Even the first CVS commit comment for osdep.c >> says "most functions are generic in fact". They are duplicated in >> qemu-img because osdep.c isn't used there. >> >> This patch moves those functions to cutils.c and removes the duplicates >> from qemu-img. > > After applying this patch, some files in tcg/ starts to emit warning > about undefined function. Oops... Actually, there are quite a few more files which don't include the header but should now. And I found even a bit more of cutils.c code duplicated in tcg.c while checking the warnings. New patch is attached. Kevin