Re: [ULOGD PATCH 1/4] Fix SQL field naming.

[Pablo Neira Ayuso <pablo@netfilter.org>]

Eric Leblond wrote:
> Hi,
> 
>> Eric Leblond wrote:
>>> diff --git a/doc/mysql-ulogd2.sql b/doc/mysql-ulogd2.sql
>>> index 304173b..6368dc7 100644
>>> --- a/doc/mysql-ulogd2.sql
>>> +++ b/doc/mysql-ulogd2.sql
>>> @@ -297,8 +297,8 @@ DROP VIEW IF EXISTS `conntrack`;
>>>  CREATE SQL SECURITY INVOKER VIEW `conntrack` AS
>>>  	SELECT _ct_id,
>>>  	       oob_family,
>>> -	       orig_ip_saddr AS orig_ip_saddr_raw,
>>> -	       orig_ip_daddr AS orig_ip_daddr_raw,
>>> +	       orig_ip_saddr AS orig_ip_saddr_bin,
>>> +	       orig_ip_daddr AS orig_ip_daddr_bin,
>>>  	       orig_ip_protocol,
>>>  	       orig_l4_sport,
>>>  	       orig_l4_dport,
>> What do we gain with this renaming?
> 
> This fix an inconsistency of field naming among the different tables and
> accross the stack NFCT IP2BIN MYSQL.In fact IP2BIN out .bin suffixed
> fields.

Makes sense. Applied. Thanks Eric.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers