From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH 3/8] [NETFILTER]: rename NF_ARP to NFPROTO_ARP and assign a non-clashing value Date: Wed, 09 Apr 2008 17:15:41 +0200 Message-ID: <47FCDD9D.7050905@trash.net> References: <5130e28c2130c57a9a07ae21c552fe7db519473c.1207668694.git.jengelh@computergmbh.de> <2a75525ff0d60f2e71df2c9c3d040d3a76451713.1207668694.git.jengelh@computergmbh.de> <47FCBC24.4020209@trash.net> <47FCC0D2.7060306@trash.net> <47FCC2F4.4030901@trash.net> <47FCC7B0.6080205@trash.net> <47FCC9CC.4070307@trash.net> <47FCD318.1030507@trash.net> <47FCD954.5000308@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org To: Jan Engelhardt Return-path: Received: from stinky.trash.net ([213.144.137.162]:50477 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751928AbYDIPPq (ORCPT ); Wed, 9 Apr 2008 11:15:46 -0400 In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-ID: Jan Engelhardt wrote: > On Wednesday 2008-04-09 16:57, Patrick McHardy wrote: >>> So let's use NFPROTO_NUM, that's a name fine by me. >> In this case its actually not the best choice since we have >> four protocols supported by netfilter and the value will be >> something like 35. Use it if you insist, I might change it >> though :) >> >> One more thing I was thinking about. The current AF values >> we need to keep are >> >> #define AF_INET 2 /* Internet IP Protocol */ >> #define AF_ATMPVC 8 /* ATM PVCs */ >> #define AF_INET6 10 /* IP version 6 */ > > And PF_UNSPEC. And PF_BRIDGE. This is becoming fun... > > Where is ATMPVC used? Cut-and-paste error, that was supposed to be AF_BRIDGE. > >> after decoupling them we don't really care about clashes >> anymore, so we might still use zero for ARP and AF_INET6 >> as highest value. > > I have a bad feeling about it, though.. maybe someone wants > to add a PF_LOCAL filter one day, and if NFPROTO_ARP is > exported, that'd be really bad - more than currently even. PF_LOCAL? And why would it matter, if we decouple the values they simply have nothing in common anymore except the a few old values for compatibility (IP,IP6,BRIDGE).