Re: [patch] fix up xfsbdstrat b0rkage

[Donald Douwsma <donaldd@sgi.com>]

David Chinner wrote:
> Not sure how this got through testing, but it's screwed.
> 
> ---
> 
> Don't error out on good I/Os in xfsbdstrat().
> 
> Signed-off-by: Dave Chinner <dgc@sgi.com>
> ---
>  fs/xfs/linux-2.6/xfs_lrw.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_lrw.c	2008-04-10 11:02:30.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_lrw.c	2008-04-10 11:40:54.533326543 +1000
> @@ -885,8 +885,10 @@ xfsbdstrat(
>  	struct xfs_buf		*bp)
>  {
>  	ASSERT(mp);
> -	if (!XFS_FORCED_SHUTDOWN(mp))
> +	if (!XFS_FORCED_SHUTDOWN(mp)) {
>  		xfs_buf_iorequest(bp);
> +		return;
> +	}
>  
>  	xfs_buftrace("XFSBDSTRAT IOERROR", bp);
>  	xfs_bioerror_relse(bp);

Looks good Dave,

Don