All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vernon Sauder <vernoninhand@gmail.com>
To: linux-input@vger.kernel.org
Cc: Nicolas Pitre <nico@marvell.com>
Subject: [PATCH] UCB1400 IRQ Probe fix
Date: Wed, 09 Apr 2008 22:37:19 -0400	[thread overview]
Message-ID: <47FD7D5F.40800@gmail.com> (raw)

The UCB1400 driver IRQ probe code fails to find an interrupt if all
the interrupts in the range 0-31 are nonprobe-able. This patch
removes the check of the return value so interrupts above 31 can be
detected.

This change may also be useful in drivers/mfd/ucb1x0-core.c but I
cannot test that on my hardware.

This patch is against 2.6.24.4. Tested on InHand Fingertip4 PXA270
board.

Signed-off-by: Vernon Sauder <vsauder@inhand.com>
Acked-by: Nicolas Pitre <nico@marvell.com>

diff -ur linux.orig/drivers/input/touchscreen/ucb1400_ts.c
linux.new/drivers/input/touchscreen/ucb1400_ts.c
--- linux.orig/drivers/input/touchscreen/ucb1400_ts.c	2008-03-24
14:49:18.000000000 -0400
+++ linux.new/drivers/input/touchscreen/ucb1400_ts.c	2008-04-03
21:40:43.000000000 -0400
@@ -429,10 +429,6 @@
   	unsigned long mask, timeout;

   	mask = probe_irq_on();
-	if (!mask) {
-		probe_irq_off(mask);
-		return -EBUSY;
-	}

   	/* Enable the ADC interrupt. */
   	ucb1400_reg_write(ucb, UCB_IE_RIS, UCB_IE_ADC);





             reply	other threads:[~2008-04-10  2:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-10  2:37 Vernon Sauder [this message]
2008-04-21 16:15 ` [PATCH] UCB1400 IRQ Probe fix Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2008-04-16 17:43 Vernon Sauder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FD7D5F.40800@gmail.com \
    --to=vernoninhand@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=nico@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.