Re: [PATCH] FCC: fix confused base / offset

[Scott Wood <scottwood@freescale.com>]

Sascha Hauer wrote:
> See bottom of this mail. The board really is a 8260 based board. Our
> bootloader does not fill in the clock values, so they are hardcoded. I'm
> not very sure about the muram entries because the dpram is organized
> slightly different on the 8260. It has some dedicated FCC space and I
> don't know how to properly encode this in the device tree.

I think the FCC space should just be left out.

>> Does the PHY negotiate OK?
> 
> Well I put some printks into the phy_read/write functions so I can say
> that it at least properly talks to the phy.

Do you get a console message indicating that the link came up?

> 	soc@f0000000 {
> 		#address-cells = <1>;
> 		#size-cells = <1>;
> 		device_type = "soc";
> 		compatible = "fsl,mpc8272", "fsl,pq2-soc";

Change the 8272 references to 8260.

> 		// Temporary -- will go away once kernel uses ranges for get_immrbase().
> 		reg = <f0000000 00053000>;

This can go away now.

> 		cpm@119c0 {
> 			#address-cells = <1>;
> 			#size-cells = <1>;
> 			compatible = "fsl,mpc8272-cpm", "fsl,cpm2";
> 			reg = <119c0 30>;
> 			ranges;
> 
> 			muram@0 {
> 				#address-cells = <1>;
> 				#size-cells = <1>;
> 				ranges = <0 0 10000>;
> 
> 				data@0 {
> 					compatible = "fsl,cpm-muram-data";
> 					reg = <0 2000 8000 800>;

reg should be <0 4000>.  Don't include parameter RAM here.

> 			ethernet@11300 {

ethernet@11320

> 				device_type = "network";
> 				compatible = "fsl,mpc8272-fcc-enet",
> 				             "fsl,cpm2-fcc-enet";
> 				reg = <11320 20 8500 100 113b0 30>;

reg = <11320 20 8500 100 113b0 1>;

> 				local-mac-address = [ 80 10 20 30 40 50 ];
> 				interrupts = <21 2>;

interrupts = <21 8>;

-Scott