From: Avi Kivity <avi@qumranet.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: Re: [PATCH] add ioctl's to save/restore mpstate
Date: Fri, 11 Apr 2008 03:10:10 +0300 [thread overview]
Message-ID: <47FEAC62.7080606@qumranet.com> (raw)
In-Reply-To: <20080407202817.GB4254@dmt>
Marcelo Tosatti wrote:
> /*
> * ioctls for VM fds
> @@ -340,5 +341,7 @@ struct kvm_s390_interrupt {
> #define KVM_S390_SET_INITIAL_PSW _IOW(KVMIO, 0x96, struct kvm_s390_psw)
> /* initial reset for s390 */
> #define KVM_S390_INITIAL_RESET _IO(KVMIO, 0x97)
> +#define KVM_GET_MP_STATE _IO(KVMIO, 0x98)
> +#define KVM_SET_MP_STATE _IO(KVMIO, 0x99)
>
This needs _IOW or _IORW to document transfer direction and structure
size. Please put the data in a structure, and document the values by
moving the #defines into linux/kvm.h
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
prev parent reply other threads:[~2008-04-11 0:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 20:28 [PATCH] add ioctl's to save/restore mpstate Marcelo Tosatti
2008-04-11 0:10 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FEAC62.7080606@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.