From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4188] Fix compiler warnings
Date: Fri, 11 Apr 2008 11:33:37 +0200 [thread overview]
Message-ID: <47FF3071.5070107@bellard.org> (raw)
In-Reply-To: <E1JkBID-0000EB-B9@cvs.savannah.gnu.org>
It would be better to use the gcc noreturn function attribute !
Fabrice.
Aurelien Jarno wrote:
> Revision: 4188
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4188
> Author: aurel32
> Date: 2008-04-11 04:55:17 +0000 (Fri, 11 Apr 2008)
>
> Log Message:
> -----------
> Fix compiler warnings
>
> (Stefan Weil)
>
> Modified Paths:
> --------------
> trunk/cpu-exec.c
>
> Modified: trunk/cpu-exec.c
> ===================================================================
> --- trunk/cpu-exec.c 2008-04-11 04:55:07 UTC (rev 4187)
> +++ trunk/cpu-exec.c 2008-04-11 04:55:17 UTC (rev 4188)
> @@ -882,6 +882,8 @@
> do it (XXX: use sigsetjmp) */
> sigprocmask(SIG_SETMASK, old_set, NULL);
> cpu_loop_exit();
> + /* never comes here */
> + return 1;
> }
> #elif defined(TARGET_SPARC)
> static inline int handle_cpu_signal(unsigned long pc, unsigned long address,
> @@ -918,6 +920,8 @@
> do it (XXX: use sigsetjmp) */
> sigprocmask(SIG_SETMASK, old_set, NULL);
> cpu_loop_exit();
> + /* never comes here */
> + return 1;
> }
> #elif defined (TARGET_PPC)
> static inline int handle_cpu_signal(unsigned long pc, unsigned long address,
>
>
>
>
>
next prev parent reply other threads:[~2008-04-11 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 4:55 [Qemu-devel] [4188] Fix compiler warnings Aurelien Jarno
2008-04-11 9:33 ` Fabrice Bellard [this message]
2008-04-11 19:13 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FF3071.5070107@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.