All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jesper Dangaard Brouer <hawk@diku.dk>
Cc: Stephen Hemminger <stephen.hemminger@vyatta.com>,
	netdev <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/7] ATM cell alignment.
Date: Fri, 11 Apr 2008 14:51:05 +0200	[thread overview]
Message-ID: <47FF5EB9.2010108@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0804092259460.21022@ask.diku.dk>

Jesper Dangaard Brouer wrote:
> @@ -87,6 +111,16 @@ int tc_calc_rtable(struct tc_ratespec *r, __u32 
> *rtab, int cell_log, unsigned mt
>          unsigned sz = ((i+1)<<cell_log);
>          if (sz < mpu)
>              sz = mpu;
> +        switch (linklayer) {
> +        case LINKLAYER_ATM:
> +            sz = tc_align_to_atm(sz);
> +            break;
> +        case LINKLAYER_ETHERNET:
> +            // No size adjustments on Ethernet
> +            break;

Couldn't this use the ARPHRD values?

  parent reply	other threads:[~2008-04-11 12:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-09 20:57 [PATCH 0/7] Final ADSL-optimizer patch series Jesper Dangaard Brouer
2008-04-09 20:59 ` [PATCH 1/7] In police, fix uninitialized "overhead" variable Jesper Dangaard Brouer
2008-04-09 21:01 ` [PATCH 2/7] ATM cell alignment Jesper Dangaard Brouer
2008-04-10 14:35   ` Chas Williams (CONTRACTOR)
2008-04-11  4:53     ` Jesper Dangaard Brouer
2008-04-11 14:18       ` Chas Williams (CONTRACTOR)
2008-04-11 12:51   ` Patrick McHardy [this message]
2008-04-11 17:35     ` Jesper Dangaard Brouer
2008-04-13  4:44       ` Patrick McHardy
2008-04-13 11:24   ` Andy Furniss
2008-04-14  5:59     ` Jesper Dangaard Brouer
2008-04-15 23:41       ` Andy Furniss
2008-04-09 21:02 ` [PATCH 3/7] Parsing linklayer types Jesper Dangaard Brouer
2008-04-09 21:03 ` [PATCH 4/7] Add linklayer parameter to filter action police Jesper Dangaard Brouer
2008-04-09 21:04 ` [PATCH 5/7] Add linklayer parameter to CBQ Jesper Dangaard Brouer
2008-04-09 21:06 ` [PATCH 6/7] Add linklayer parameter to HTB Jesper Dangaard Brouer
2008-04-09 21:07 ` [PATCH 7/7] Add linklayer parameter to TBF Jesper Dangaard Brouer
2008-04-14  5:40 ` [PATCH 0/7] Final ADSL-optimizer patch series David Miller
2008-04-17 17:10 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FF5EB9.2010108@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=hawk@diku.dk \
    --cc=netdev@vger.kernel.org \
    --cc=stephen.hemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.