From: Steve Dickson <SteveD@redhat.com>
To: Eric Paris <eparis@redhat.com>
Cc: Fedora Kernel Mailing list <fedora-kernel-list@redhat.com>,
Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS Client mounts hang when exported directory do not exist
Date: Fri, 11 Apr 2008 12:10:18 -0400 [thread overview]
Message-ID: <47FF8D6A.9040902@RedHat.com> (raw)
In-Reply-To: <1207927210.3379.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
Eric Paris wrote:
> On Fri, 2008-04-11 at 11:12 -0400, Steve Dickson wrote:
>> This patch fixes a regression that was introduced by the string based mounts.
>>
>> nfs_mount() statically returns -EACCES for every error returned
>> by the remote mounted. This is incorrect because -EACCES is
>> an non-fatal error to the mount.nfs command. This error causes
>> mount.nfs to retry the mount even in the case when the exported
>> directory does not exist.
>>
>> This patch maps the errors returned by the remote mountd into
>> valid errno values, exactly how it was done pre-string based
>> mounts. By returning the correct errno enables mount.nfs
>> to do the right thing.
>
> Does this mean the EACCES can/will again become fatal in mount.nfs like
> it used to be?
EACCES is still a non-fatal error as it was... The problem is the
kernel was should have been returning ENOENT, which is a fatal error,
instead of EACCES.
steved.
next prev parent reply other threads:[~2008-04-11 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 15:12 [PATCH] NFS Client mounts hang when exported directory do not exist Steve Dickson
[not found] ` <47FF7FCC.2050403-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-04-11 15:20 ` Eric Paris
[not found] ` <1207927210.3379.1.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-04-11 16:10 ` Steve Dickson [this message]
[not found] ` <47FF8D6A.9040902-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-04-11 18:35 ` Eric Paris
[not found] ` <1207938902.3379.7.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-04-12 0:14 ` Steve Dickson
2008-04-11 16:22 ` Chuck Lever
2008-04-11 16:37 ` Steve Dickson
-- strict thread matches above, loose matches on Subject: below --
2008-04-11 16:05 Steve Dickson
2008-04-12 0:03 Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FF8D6A.9040902@RedHat.com \
--to=steved@redhat.com \
--cc=eparis@redhat.com \
--cc=fedora-kernel-list@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.