From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF2C6623 for ; Tue, 28 Feb 2023 03:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677553699; x=1709089699; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=aFeH2nXRI4dqYxpamP5Js4ORwQlkFpZJtH/0H8oYJnw=; b=D103bOOs8I9kZ9baOiftgO8dQBX4yVbPHUU52NXWxeRT4s91uk3c2Qwp 1Is0mwuzxWJvLkoXywai8ENraAiGCBQJrvtr4n39uehvrSlYbqrhjwJGn QopvbALNpDCrNrrMoePH85LIgvjRpeY2/XwIBY7KhNbmqQ6Zqb+bTW6ya yfnMNxSf4UMZQfY7n8pePEeMQwSd7uJefmyuIIF161tu78VLRZqSIvM1h iXfGWmASVa52lu8yf2Mfm9CTAlwlCpMwutF5a5ftpHzKBbb//6lVS9UbO +/zFq50161fk8bpICGvf0tMjDNSYzDslNIfnW+bpabb7bzeC8FCT5wenK Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="336319430" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="336319430" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 19:08:19 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="783654168" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="783654168" Received: from ticela-az-102.amr.corp.intel.com (HELO [10.209.55.154]) ([10.209.55.154]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 19:08:18 -0800 Message-ID: <47a88e5f-ee56-9c4b-e134-e018cd6dc49e@linux.intel.com> Date: Mon, 27 Feb 2023 19:08:17 -0800 Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] PCI/ATS: Add a helper function to configure ATS STU of a PF. Content-Language: en-US To: Ganapatrao Kulkarni , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, joro@8bytes.org, bhelgaas@google.com, robin.murphy@arm.com, will@kernel.org Cc: jean-philippe@linaro.org, darren@os.amperecomputing.com, scott@os.amperecomputing.com References: <20230227132151.1907480-1-gankulkarni@os.amperecomputing.com> <20230227132151.1907480-2-gankulkarni@os.amperecomputing.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/27/23 6:53 PM, Ganapatrao Kulkarni wrote: > > > On 28-02-2023 12:59 am, Sathyanarayanan Kuppuswamy wrote: >> Hi, >> >> On 2/27/23 5:21 AM, Ganapatrao Kulkarni wrote: >>> As per PCI specification (PCI Express Base Specification Revision >>> 6.0, Section 10.5) both PF and VFs of a PCI EP are permitted to be enabled >>> independently for ATS capability, however the STU(Smallest Translation >>> Unit) is shared between PF and VFs. For VFs, it is hardwired to Zero and >>> the associated PF's value applies to VFs. >>> >>> In the current code, the STU is being configured while enabling the PF ATS. >>> Hence, it is not able to enable ATS for VFs, if it is not enabled on the >>> associated PF already.> >>> Adding a function pci_ats_stu_configure(), which can be called to >>> configure the STU during PF enumeration. >>> Latter enumerations of VFs can successfully enable ATS independently. >> >> Why not enable ATS in PF before enabling it in VF? Just updating STU of >> PF and not enabling it seem odd. > > More details are in PATCH 0/2 and 2/2. > > Also, This was discussed at > https://lore.kernel.org/linux-arm-kernel/20230221154624.GA3701506@bhelgaas/T/ > I agree with Bjorn's comments. It is incorrect to directly configure PF registers from VF enable function. It is a buggy fix. My question is, why not ensure PF ATS is configured and enabled before enabling ATS for VF. Anyway, PF device will be enumerated before VF, right? >> >>> >>> Signed-off-by: Ganapatrao Kulkarni >>> --- >>>   drivers/pci/ats.c       | 32 ++++++++++++++++++++++++++++++-- >>>   include/linux/pci-ats.h |  1 + >>>   2 files changed, 31 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c >>> index f9cc2e10b676..70e1982efdb4 100644 >>> --- a/drivers/pci/ats.c >>> +++ b/drivers/pci/ats.c >>> @@ -46,6 +46,34 @@ bool pci_ats_supported(struct pci_dev *dev) >>>   } >>>   EXPORT_SYMBOL_GPL(pci_ats_supported); >>>   +/** >>> + * pci_ats_stu_configure - Configure STU of a PF. >>> + * @dev: the PCI device >>> + * @ps: the IOMMU page shift >>> + * >>> + * Returns 0 on success, or negative on failure. >>> + */ >>> +int pci_ats_stu_configure(struct pci_dev *dev, int ps) >>> +{ >>> +    u16 ctrl; >>> + >>> +    if (dev->ats_enabled || dev->is_virtfn) >>> +        return 0; >>> + >>> +    if (!pci_ats_supported(dev)) >>> +        return -EINVAL; >>> + >>> +    if (ps < PCI_ATS_MIN_STU) >>> +        return -EINVAL; >>> + >>> +    dev->ats_stu = ps; >>> +    ctrl = PCI_ATS_CTRL_STU(dev->ats_stu - PCI_ATS_MIN_STU); >>> +    pci_write_config_word(dev, dev->ats_cap + PCI_ATS_CTRL, ctrl); >> >> If you just want to update the STU, don't overwrite other fields. > > Can be read modify write, but felt not necessary, since all other fields are at default value zero. It may not always be true. If there is a case where AMAD and AMAE attribute values are configured independently, then your change can overwrite it. IMO, since your intention is to update STU, I recommend just updating it. > >> >>> + >>> +    return 0; >>> +} >>> +EXPORT_SYMBOL_GPL(pci_ats_stu_configure); >>> + >>>   /** >>>    * pci_enable_ats - enable the ATS capability >>>    * @dev: the PCI device >>> @@ -68,8 +96,8 @@ int pci_enable_ats(struct pci_dev *dev, int ps) >>>           return -EINVAL; >>>         /* >>> -     * Note that enabling ATS on a VF fails unless it's already enabled >>> -     * with the same STU on the PF. >>> +     * Note that enabling ATS on a VF fails unless it's already >>> +     * configured with the same STU on the PF. >>>        */ >>>       ctrl = PCI_ATS_CTRL_ENABLE; >>>       if (dev->is_virtfn) { >>> diff --git a/include/linux/pci-ats.h b/include/linux/pci-ats.h >>> index df54cd5b15db..9b40eb555124 100644 >>> --- a/include/linux/pci-ats.h >>> +++ b/include/linux/pci-ats.h >>> @@ -8,6 +8,7 @@ >>>   /* Address Translation Service */ >>>   bool pci_ats_supported(struct pci_dev *dev); >>>   int pci_enable_ats(struct pci_dev *dev, int ps); >>> +int pci_ats_stu_configure(struct pci_dev *dev, int ps); >> >> What about dummy declaration for !CONFIG_PCI_ATS case? > > Thanks, I overlooked else case. >> >>>   void pci_disable_ats(struct pci_dev *dev); >>>   int pci_ats_queue_depth(struct pci_dev *dev); >>>   int pci_ats_page_aligned(struct pci_dev *dev); >> > > > Thanks, > Ganapat -- Sathyanarayanan Kuppuswamy Linux Kernel Developer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23600C7EE23 for ; Tue, 28 Feb 2023 03:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oni9eAxsvo1o6fR8bJqo7SCZkYhN8SJkIV3zc7EzEmw=; b=c9BV/tB/iF4oJb 4jo8pZg92AeHTkFzvzClmM0MKs05OzMr86/GY4O7rsvqMUfgdzDchl0l62iHoHIQyLkyO9bQl+HSF MMul9X7lKXYuRDOiPs+JC+xDZONwJULIcdygjtH16gMA0+wESNRq7KJremFhDMnHof9ubcD/xOuVu c8TowSeb0Q+8ZRDCALnmrSfxQueKIALkcaJuTnkx5mL+BYv6JokRzOiZ16u11Aagj4P7tDr7HgGTd 3k95qn+ae+EPUZv7HmFcQ0QSQLZ7ciOjvcQBzrQzJ29rGz70KX90IATExnRgmPwvUo2bFNeXqFows F7E94a2IX+CArrvXZCww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWqLw-00Btir-QB; Tue, 28 Feb 2023 03:08:32 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWqLt-00Btgs-7n for linux-arm-kernel@lists.infradead.org; Tue, 28 Feb 2023 03:08:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677553709; x=1709089709; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=aFeH2nXRI4dqYxpamP5Js4ORwQlkFpZJtH/0H8oYJnw=; b=OdmQuhPq2wVjBBgKvb/EPd9JrHPhLkI80WoDXOS6DsWHUcvtWB031u9v HCehfCaLs28XMjaVVly2quN6tMMzTQyE7EUrYD6tNfRINb0I936scnDdR L1dMcCj0NL/LwuEGqX3MmpssYexfOAEh5HQQbFF/Rw+kCDhP+KsmAMLA0 V0SMez742xzsUqAWVap9XiX2ty3EMKz70tzYcObdhj0S419HSriHj8kTT D049NHJSVaIazDfUGXHndvDv/s6CA/NQM/BRqGMZxN7dNmRBQvO5OMHZX VA3LYQJS3cYoSr0NBnLyy3AfA9VNw3MERrjYiV8X4FsFhq7PVnQ/a+NZR w==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="336319427" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="336319427" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 19:08:19 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="783654168" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="783654168" Received: from ticela-az-102.amr.corp.intel.com (HELO [10.209.55.154]) ([10.209.55.154]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 19:08:18 -0800 Message-ID: <47a88e5f-ee56-9c4b-e134-e018cd6dc49e@linux.intel.com> Date: Mon, 27 Feb 2023 19:08:17 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.4.2 Subject: Re: [PATCH 1/2] PCI/ATS: Add a helper function to configure ATS STU of a PF. Content-Language: en-US To: Ganapatrao Kulkarni , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, joro@8bytes.org, bhelgaas@google.com, robin.murphy@arm.com, will@kernel.org Cc: jean-philippe@linaro.org, darren@os.amperecomputing.com, scott@os.amperecomputing.com References: <20230227132151.1907480-1-gankulkarni@os.amperecomputing.com> <20230227132151.1907480-2-gankulkarni@os.amperecomputing.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_190829_347509_1168CAF6 X-CRM114-Status: GOOD ( 24.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyLzI3LzIzIDY6NTMgUE0sIEdhbmFwYXRyYW8gS3Vsa2Fybmkgd3JvdGU6Cj4gCj4gCj4g T24gMjgtMDItMjAyMyAxMjo1OSBhbSwgU2F0aHlhbmFyYXlhbmFuIEt1cHB1c3dhbXkgd3JvdGU6 Cj4+IEhpLAo+Pgo+PiBPbiAyLzI3LzIzIDU6MjEgQU0sIEdhbmFwYXRyYW8gS3Vsa2Fybmkgd3Jv dGU6Cj4+PiBBcyBwZXIgUENJIHNwZWNpZmljYXRpb24gKFBDSSBFeHByZXNzIEJhc2UgU3BlY2lm aWNhdGlvbiBSZXZpc2lvbgo+Pj4gNi4wLCBTZWN0aW9uIDEwLjUpIGJvdGggUEYgYW5kIFZGcyBv ZiBhIFBDSSBFUCBhcmUgcGVybWl0dGVkIHRvIGJlIGVuYWJsZWQKPj4+IGluZGVwZW5kZW50bHkg Zm9yIEFUUyBjYXBhYmlsaXR5LCBob3dldmVyIHRoZSBTVFUoU21hbGxlc3QgVHJhbnNsYXRpb24K Pj4+IFVuaXQpIGlzIHNoYXJlZCBiZXR3ZWVuIFBGIGFuZCBWRnMuIEZvciBWRnMsIGl0IGlzIGhh cmR3aXJlZCB0byBaZXJvIGFuZAo+Pj4gdGhlIGFzc29jaWF0ZWQgUEYncyB2YWx1ZSBhcHBsaWVz IHRvIFZGcy4KPj4+Cj4+PiBJbiB0aGUgY3VycmVudCBjb2RlLCB0aGUgU1RVIGlzIGJlaW5nIGNv bmZpZ3VyZWQgd2hpbGUgZW5hYmxpbmcgdGhlIFBGIEFUUy4KPj4+IEhlbmNlLCBpdCBpcyBub3Qg YWJsZSB0byBlbmFibGUgQVRTIGZvciBWRnMsIGlmIGl0IGlzIG5vdCBlbmFibGVkIG9uIHRoZQo+ Pj4gYXNzb2NpYXRlZCBQRiBhbHJlYWR5Lj4KPj4+IEFkZGluZyBhIGZ1bmN0aW9uIHBjaV9hdHNf c3R1X2NvbmZpZ3VyZSgpLCB3aGljaCBjYW4gYmUgY2FsbGVkIHRvCj4+PiBjb25maWd1cmUgdGhl IFNUVSBkdXJpbmcgUEYgZW51bWVyYXRpb24uCj4+PiBMYXR0ZXIgZW51bWVyYXRpb25zIG9mIFZG cyBjYW4gc3VjY2Vzc2Z1bGx5IGVuYWJsZSBBVFMgaW5kZXBlbmRlbnRseS4KPj4KPj4gV2h5IG5v dCBlbmFibGUgQVRTIGluIFBGIGJlZm9yZSBlbmFibGluZyBpdCBpbiBWRj8gSnVzdCB1cGRhdGlu ZyBTVFUgb2YKPj4gUEYgYW5kIG5vdCBlbmFibGluZyBpdCBzZWVtIG9kZC4KPiAKPiBNb3JlIGRl dGFpbHMgYXJlIGluIFBBVENIIDAvMiBhbmQgMi8yLgo+IAo+IEFsc28sIFRoaXMgd2FzIGRpc2N1 c3NlZCBhdAo+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LWFybS1rZXJuZWwvMjAyMzAy MjExNTQ2MjQuR0EzNzAxNTA2QGJoZWxnYWFzL1QvCj4gCgpJIGFncmVlIHdpdGggQmpvcm4ncyBj b21tZW50cy4gSXQgaXMgaW5jb3JyZWN0IHRvIGRpcmVjdGx5IGNvbmZpZ3VyZSBQRgpyZWdpc3Rl cnMgZnJvbSBWRiBlbmFibGUgZnVuY3Rpb24uIEl0IGlzIGEgYnVnZ3kgZml4LgoKTXkgcXVlc3Rp b24gaXMsIHdoeSBub3QgZW5zdXJlIFBGIEFUUyBpcyBjb25maWd1cmVkIGFuZCBlbmFibGVkIGJl Zm9yZSBlbmFibGluZwpBVFMgZm9yIFZGLiBBbnl3YXksIFBGIGRldmljZSB3aWxsIGJlIGVudW1l cmF0ZWQgYmVmb3JlIFZGLCByaWdodD8KCj4+Cj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogR2FuYXBh dHJhbyBLdWxrYXJuaSA8Z2Fua3Vsa2FybmlAb3MuYW1wZXJlY29tcHV0aW5nLmNvbT4KPj4+IC0t LQo+Pj4gwqAgZHJpdmVycy9wY2kvYXRzLmPCoMKgwqDCoMKgwqAgfCAzMiArKysrKysrKysrKysr KysrKysrKysrKysrKysrKystLQo+Pj4gwqAgaW5jbHVkZS9saW51eC9wY2ktYXRzLmggfMKgIDEg Kwo+Pj4gwqAgMiBmaWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9hdHMuYyBiL2RyaXZlcnMvcGNpL2F0 cy5jCj4+PiBpbmRleCBmOWNjMmUxMGI2NzYuLjcwZTE5ODJlZmRiNCAxMDA2NDQKPj4+IC0tLSBh L2RyaXZlcnMvcGNpL2F0cy5jCj4+PiArKysgYi9kcml2ZXJzL3BjaS9hdHMuYwo+Pj4gQEAgLTQ2 LDYgKzQ2LDM0IEBAIGJvb2wgcGNpX2F0c19zdXBwb3J0ZWQoc3RydWN0IHBjaV9kZXYgKmRldikK Pj4+IMKgIH0KPj4+IMKgIEVYUE9SVF9TWU1CT0xfR1BMKHBjaV9hdHNfc3VwcG9ydGVkKTsKPj4+ IMKgICsvKioKPj4+ICsgKiBwY2lfYXRzX3N0dV9jb25maWd1cmUgLSBDb25maWd1cmUgU1RVIG9m IGEgUEYuCj4+PiArICogQGRldjogdGhlIFBDSSBkZXZpY2UKPj4+ICsgKiBAcHM6IHRoZSBJT01N VSBwYWdlIHNoaWZ0Cj4+PiArICoKPj4+ICsgKiBSZXR1cm5zIDAgb24gc3VjY2Vzcywgb3IgbmVn YXRpdmUgb24gZmFpbHVyZS4KPj4+ICsgKi8KPj4+ICtpbnQgcGNpX2F0c19zdHVfY29uZmlndXJl KHN0cnVjdCBwY2lfZGV2ICpkZXYsIGludCBwcykKPj4+ICt7Cj4+PiArwqDCoMKgIHUxNiBjdHJs Owo+Pj4gKwo+Pj4gK8KgwqDCoCBpZiAoZGV2LT5hdHNfZW5hYmxlZCB8fCBkZXYtPmlzX3ZpcnRm bikKPj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsKPj4+ICsKPj4+ICvCoMKgwqAgaWYgKCFw Y2lfYXRzX3N1cHBvcnRlZChkZXYpKQo+Pj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFM Owo+Pj4gKwo+Pj4gK8KgwqDCoCBpZiAocHMgPCBQQ0lfQVRTX01JTl9TVFUpCj4+PiArwqDCoMKg wqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+PiArCj4+PiArwqDCoMKgIGRldi0+YXRzX3N0dSA9 IHBzOwo+Pj4gK8KgwqDCoCBjdHJsID0gUENJX0FUU19DVFJMX1NUVShkZXYtPmF0c19zdHUgLSBQ Q0lfQVRTX01JTl9TVFUpOwo+Pj4gK8KgwqDCoCBwY2lfd3JpdGVfY29uZmlnX3dvcmQoZGV2LCBk ZXYtPmF0c19jYXAgKyBQQ0lfQVRTX0NUUkwsIGN0cmwpOwo+Pgo+PiBJZiB5b3UganVzdCB3YW50 IHRvIHVwZGF0ZSB0aGUgU1RVLCBkb24ndCBvdmVyd3JpdGUgb3RoZXIgZmllbGRzLgo+IAo+IENh biBiZSByZWFkIG1vZGlmeSB3cml0ZSwgYnV0IGZlbHQgbm90IG5lY2Vzc2FyeSwgc2luY2UgYWxs IG90aGVyIGZpZWxkcyBhcmUgYXQgZGVmYXVsdCB2YWx1ZSB6ZXJvLgoKSXQgbWF5IG5vdCBhbHdh eXMgYmUgdHJ1ZS4gSWYgdGhlcmUgaXMgYSBjYXNlIHdoZXJlIEFNQUQgYW5kIEFNQUUgYXR0cmli dXRlIHZhbHVlcyBhcmUKY29uZmlndXJlZCBpbmRlcGVuZGVudGx5LCB0aGVuIHlvdXIgY2hhbmdl IGNhbiBvdmVyd3JpdGUgaXQuCgpJTU8sIHNpbmNlIHlvdXIgaW50ZW50aW9uIGlzIHRvIHVwZGF0 ZSBTVFUsIEkgcmVjb21tZW5kIGp1c3QgdXBkYXRpbmcgaXQuCgo+IAo+Pgo+Pj4gKwo+Pj4gK8Kg wqDCoCByZXR1cm4gMDsKPj4+ICt9Cj4+PiArRVhQT1JUX1NZTUJPTF9HUEwocGNpX2F0c19zdHVf Y29uZmlndXJlKTsKPj4+ICsKPj4+IMKgIC8qKgo+Pj4gwqDCoCAqIHBjaV9lbmFibGVfYXRzIC0g ZW5hYmxlIHRoZSBBVFMgY2FwYWJpbGl0eQo+Pj4gwqDCoCAqIEBkZXY6IHRoZSBQQ0kgZGV2aWNl Cj4+PiBAQCAtNjgsOCArOTYsOCBAQCBpbnQgcGNpX2VuYWJsZV9hdHMoc3RydWN0IHBjaV9kZXYg KmRldiwgaW50IHBzKQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiAtRUlOVkFMOwo+Pj4g wqAgwqDCoMKgwqDCoCAvKgo+Pj4gLcKgwqDCoMKgICogTm90ZSB0aGF0IGVuYWJsaW5nIEFUUyBv biBhIFZGIGZhaWxzIHVubGVzcyBpdCdzIGFscmVhZHkgZW5hYmxlZAo+Pj4gLcKgwqDCoMKgICog d2l0aCB0aGUgc2FtZSBTVFUgb24gdGhlIFBGLgo+Pj4gK8KgwqDCoMKgICogTm90ZSB0aGF0IGVu YWJsaW5nIEFUUyBvbiBhIFZGIGZhaWxzIHVubGVzcyBpdCdzIGFscmVhZHkKPj4+ICvCoMKgwqDC oCAqIGNvbmZpZ3VyZWQgd2l0aCB0aGUgc2FtZSBTVFUgb24gdGhlIFBGLgo+Pj4gwqDCoMKgwqDC oMKgICovCj4+PiDCoMKgwqDCoMKgIGN0cmwgPSBQQ0lfQVRTX0NUUkxfRU5BQkxFOwo+Pj4gwqDC oMKgwqDCoCBpZiAoZGV2LT5pc192aXJ0Zm4pIHsKPj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xp bnV4L3BjaS1hdHMuaCBiL2luY2x1ZGUvbGludXgvcGNpLWF0cy5oCj4+PiBpbmRleCBkZjU0Y2Q1 YjE1ZGIuLjliNDBlYjU1NTEyNCAxMDA2NDQKPj4+IC0tLSBhL2luY2x1ZGUvbGludXgvcGNpLWF0 cy5oCj4+PiArKysgYi9pbmNsdWRlL2xpbnV4L3BjaS1hdHMuaAo+Pj4gQEAgLTgsNiArOCw3IEBA Cj4+PiDCoCAvKiBBZGRyZXNzIFRyYW5zbGF0aW9uIFNlcnZpY2UgKi8KPj4+IMKgIGJvb2wgcGNp X2F0c19zdXBwb3J0ZWQoc3RydWN0IHBjaV9kZXYgKmRldik7Cj4+PiDCoCBpbnQgcGNpX2VuYWJs ZV9hdHMoc3RydWN0IHBjaV9kZXYgKmRldiwgaW50IHBzKTsKPj4+ICtpbnQgcGNpX2F0c19zdHVf Y29uZmlndXJlKHN0cnVjdCBwY2lfZGV2ICpkZXYsIGludCBwcyk7Cj4+Cj4+IFdoYXQgYWJvdXQg ZHVtbXkgZGVjbGFyYXRpb24gZm9yICFDT05GSUdfUENJX0FUUyBjYXNlPwo+IAo+IFRoYW5rcywg SSBvdmVybG9va2VkIGVsc2UgY2FzZS4KPj4KPj4+IMKgIHZvaWQgcGNpX2Rpc2FibGVfYXRzKHN0 cnVjdCBwY2lfZGV2ICpkZXYpOwo+Pj4gwqAgaW50IHBjaV9hdHNfcXVldWVfZGVwdGgoc3RydWN0 IHBjaV9kZXYgKmRldik7Cj4+PiDCoCBpbnQgcGNpX2F0c19wYWdlX2FsaWduZWQoc3RydWN0IHBj aV9kZXYgKmRldik7Cj4+Cj4gCj4gCj4gVGhhbmtzLAo+IEdhbmFwYXQKCi0tIApTYXRoeWFuYXJh eWFuYW4gS3VwcHVzd2FteQpMaW51eCBLZXJuZWwgRGV2ZWxvcGVyCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==