From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81229C3600B for ; Mon, 31 Mar 2025 14:52:51 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.932724.1334807 (Exim 4.92) (envelope-from ) id 1tzGV9-00053d-18; Mon, 31 Mar 2025 14:52:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 932724.1334807; Mon, 31 Mar 2025 14:52:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzGV8-00053W-UL; Mon, 31 Mar 2025 14:52:34 +0000 Received: by outflank-mailman (input) for mailman id 932724; Mon, 31 Mar 2025 14:52:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tzGV7-00053Q-4x for xen-devel@lists.xenproject.org; Mon, 31 Mar 2025 14:52:33 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c565c32c-0e3f-11f0-9ffb-bf95429c2676; Mon, 31 Mar 2025 16:52:30 +0200 (CEST) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5e5e8274a74so7240396a12.1 for ; Mon, 31 Mar 2025 07:52:31 -0700 (PDT) Received: from [192.168.1.5] (user-109-243-64-225.play-internet.pl. [109.243.64.225]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac71961f8f0sm633929666b.95.2025.03.31.07.52.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Mar 2025 07:52:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c565c32c-0e3f-11f0-9ffb-bf95429c2676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743432750; x=1744037550; darn=lists.xenproject.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=56j89lkfPfxSdGbzQRzqFqwelwa8evuVeQi8eK4fRqA=; b=hNzi5PGYm5HRzAos8Yr6o9uC20OslZP/nZKWw2+Cq0dqPhm5v7Gs7lqH6jU7u/6J0J 1FllGhAWaYSHvlVTN5SnFHy9NPWKJqo0FdEa/MK/ynyj8kGfC34BbCkK/3k0OGn7XVY6 efeYlRD0CUng50tL8VWAgR/YSB7oEh0caZmQ6UbjyD7lfiR+z43PwHnSktrZNhqFT8eN ZZTT2ylxIv8Fki08KeVRF+KFDwtEIzb+CPlyWAObcHPYQZeQSRxXEkv90bpwlN627iER 3xhQPgIEQ8z2ZSJLIECy+Xr8o7tG6u8PCMMRreV8HrBYkD8NzgVtdxwSEHgngWqCy8uZ CfRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743432750; x=1744037550; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=56j89lkfPfxSdGbzQRzqFqwelwa8evuVeQi8eK4fRqA=; b=kmUFg15EGZCu3VMOPVmtMIhegGE9pgFxJr0SFKQpfcBODXL9u4a35Uf+F/Jckj09Yr NNn6dyBUDXXaKQ9p31Xetd3EUcY8kqCgWU779o0toPuq56PctIx4+tZajBcKs7/rhoHw h0MPlDLCwcOVuuK1AagegnF33s8oPfwbCSR3xO1g0aNNtsoIFDo3VBGAYEZNFgwFDsdd ZtW2c4t3eiLyVjo8D8OP5fq+FRZbM5+ZGphWsz9A+K4qd9JoJXErfDJYEhDWNNozWVBz hwHmzSgrYeAfFHT9TA6bptLT3sSj6vxxzTxN5akPjSQ2lIh5tDVu+WLR/QFXtzguR/qc oZEQ== X-Forwarded-Encrypted: i=1; AJvYcCWUkWh541SOU2Zsx7ZuBeeTcCU2rq68UVmB7kwMba30f9BD37s+4Mcsc+50HsF6u+WG38zvRg4H+5A=@lists.xenproject.org X-Gm-Message-State: AOJu0Yza8Tap9rxrXdIo6dc7sjkws39DAyRIaw8qhDigAcf48wbmeeiw /t6j3PDS/kHHZMXA077iwyTyV+v2Sw4CCoToO/BVXe4i9zXyZoAY X-Gm-Gg: ASbGncuzpiexFEabn2WpUa7nsRX3+6coOQB/KgNvp1zMSyqKsOxZKiUT8UUrVN92RSF G1PWi1irRfUPCgQugNcj9ntYclmFZDUZ84+BArNAR8Xtx0AmkNhhmi1YABFLa3sD6fUZDFMoSXE zSnH2FxwMb0CTYQI9ugr3GCso0/fLFajur9X6UZivHCEQjmthl/xzh4p8R0LpvMC4MOXoGClRpl TwpSEhoT4wzFc3Po3jrdhdBG1UiBilxz5yv1j1yl6o1Az3MFLpY+LNC5NCcM8wo82i2y8ZKGw3B j3JoLae3NHJZ7Kkl2nOt14Ojp0Dsknr/ln2+g7qF8+yAjXe56uYns88YSkBVEytrzmVqCpKf7KL 0u5Ui7r/JaIm6HzS0ZwlH X-Google-Smtp-Source: AGHT+IGiel+6UOkM8sHCVhhK+uGCOL1mG+DNamM7lCeVBXzG7Q+ndfapxQCHRQvG3BGBAvMh4rkRHg== X-Received: by 2002:a17:907:2ce4:b0:abf:4da0:28e3 with SMTP id a640c23a62f3a-ac7389bb03amr835434866b.18.1743432750170; Mon, 31 Mar 2025 07:52:30 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------NOEJoo4c3yVrXwBVlKSVL3pd" Message-ID: <47abb093-90ed-4661-943f-fa35bcb655c7@gmail.com> Date: Mon, 31 Mar 2025 16:52:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 15/16] riscv: Remove asm/byteorder.h To: Andrew Cooper , Xen-devel Cc: Anthony PERARD , Michal Orzel , Jan Beulich , Julien Grall , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Shawn Anastasio , "Daniel P . Smith" , Lin Liu References: <20250328134427.874848-1-andrew.cooper3@citrix.com> <20250328134427.874848-16-andrew.cooper3@citrix.com> Content-Language: en-US From: Oleksii Kurochko In-Reply-To: <20250328134427.874848-16-andrew.cooper3@citrix.com> This is a multi-part message in MIME format. --------------NOEJoo4c3yVrXwBVlKSVL3pd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/28/25 2:44 PM, Andrew Cooper wrote: > With the common code moved fully onto xen/byteorder.h, clean up the dregs. > > The use of byteorder.h in io.h appears to have been copy&paste from ARM. It's > not needed, but macros and types are. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by:Oleksii Kurochko Thanks. ~ Oleksii > --- > CC: Anthony PERARD > CC: Michal Orzel > CC: Jan Beulich > CC: Julien Grall > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Shawn Anastasio > CC: Oleksii Kurochko > CC: Daniel P. Smith > CC: Lin Liu > > v5: > * New > --- > xen/arch/riscv/include/asm/byteorder.h | 14 -------------- > xen/arch/riscv/include/asm/io.h | 3 ++- > 2 files changed, 2 insertions(+), 15 deletions(-) > delete mode 100644 xen/arch/riscv/include/asm/byteorder.h > > diff --git a/xen/arch/riscv/include/asm/byteorder.h b/xen/arch/riscv/include/asm/byteorder.h > deleted file mode 100644 > index a32bca02df38..000000000000 > --- a/xen/arch/riscv/include/asm/byteorder.h > +++ /dev/null > @@ -1,14 +0,0 @@ > -#ifndef ASM__RISCV__BYTEORDER_H > -#define ASM__RISCV__BYTEORDER_H > - > -#include > - > -#endif /* ASM__RISCV__BYTEORDER_H */ > -/* > - * Local variables: > - * mode: C > - * c-file-style: "BSD" > - * c-basic-offset: 4 > - * indent-tabs-mode: nil > - * End: > - */ > diff --git a/xen/arch/riscv/include/asm/io.h b/xen/arch/riscv/include/asm/io.h > index 55f329dde321..8bab4ffa0390 100644 > --- a/xen/arch/riscv/include/asm/io.h > +++ b/xen/arch/riscv/include/asm/io.h > @@ -38,7 +38,8 @@ > #ifndef ASM__RISCV__IO_H > #define ASM__RISCV__IO_H > > -#include > +#include > +#include > > /* > * The RISC-V ISA doesn't yet specify how to query or modify PMAs, so we can't --------------NOEJoo4c3yVrXwBVlKSVL3pd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 3/28/25 2:44 PM, Andrew Cooper wrote:
With the common code moved fully onto xen/byteorder.h, clean up the dregs.

The use of byteorder.h in io.h appears to have been copy&paste from ARM.  It's
not needed, but macros and types are.

No functional change.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

Thanks.
~ Oleksii
---
CC: Anthony PERARD <anthony.perard@vates.tech>
CC: Michal Orzel <michal.orzel@amd.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Julien Grall <julien@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
CC: Bertrand Marquis <bertrand.marquis@arm.com>
CC: Shawn Anastasio <sanastasio@raptorengineering.com>
CC: Oleksii Kurochko <oleksii.kurochko@gmail.com>
CC: Daniel P. Smith <dpsmith@apertussolutions.com>
CC: Lin Liu <lin.liu@citrix.com>

v5:
 * New
---
 xen/arch/riscv/include/asm/byteorder.h | 14 --------------
 xen/arch/riscv/include/asm/io.h        |  3 ++-
 2 files changed, 2 insertions(+), 15 deletions(-)
 delete mode 100644 xen/arch/riscv/include/asm/byteorder.h

diff --git a/xen/arch/riscv/include/asm/byteorder.h b/xen/arch/riscv/include/asm/byteorder.h
deleted file mode 100644
index a32bca02df38..000000000000
--- a/xen/arch/riscv/include/asm/byteorder.h
+++ /dev/null
@@ -1,14 +0,0 @@
-#ifndef ASM__RISCV__BYTEORDER_H
-#define ASM__RISCV__BYTEORDER_H
-
-#include <xen/byteorder.h>
-
-#endif /* ASM__RISCV__BYTEORDER_H */
-/*
- * Local variables:
- * mode: C
- * c-file-style: "BSD"
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */
diff --git a/xen/arch/riscv/include/asm/io.h b/xen/arch/riscv/include/asm/io.h
index 55f329dde321..8bab4ffa0390 100644
--- a/xen/arch/riscv/include/asm/io.h
+++ b/xen/arch/riscv/include/asm/io.h
@@ -38,7 +38,8 @@
 #ifndef ASM__RISCV__IO_H
 #define ASM__RISCV__IO_H
 
-#include <asm/byteorder.h>
+#include <xen/macros.h>
+#include <xen/types.h>
 
 /*
  * The RISC-V ISA doesn't yet specify how to query or modify PMAs, so we can't
--------------NOEJoo4c3yVrXwBVlKSVL3pd--