From: Hans de Goede <hdegoede@redhat.com>
To: "Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
markgross@kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Sanket.Goswami@amd.com, mario.limonciello@amd.com,
platform-driver-x86@vger.kernel.org,
Harsh Jain <Harsh.Jain@amd.com>
Subject: Re: [PATCH v4 2/2] platform/x86/amd/pmc: Add dump_custom_stb module parameter
Date: Wed, 4 Oct 2023 17:10:52 +0200 [thread overview]
Message-ID: <47babe3e-052f-d816-9789-5c8ae4728e78@redhat.com> (raw)
In-Reply-To: <844d0ef1-a09c-4c8a-aa14-d3487e3289f9@amd.com>
Hi Shyam,
On 10/4/23 14:11, Shyam Sundar S K wrote:
<snip>
> Thank you for the detailed feedback. I will make these changes and see
> if that helps - will need some time do tests and come back on this.
>
> Meanwhile, is it OK for you to take changes in v4 1/2 atleast? So that
> I don't need to respin it again (assuming there are no remarks for 1/2).
Note I have a new pdx86 co-maintainer Ilpo who is merging the patches
leading up to the 6.7 merge window (Ilpo and I plan to take turns for this).
IMHO it will be easier for Ilpo to merge the whole series in one
go when it is ready.
Note when addressing my remarks please split any fixes for the existing
functionality out into separate patches vs the new dump_custom_stb
support.
Regards,
Hans
next prev parent reply other threads:[~2023-10-04 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 14:20 [PATCH v4 1/2] platform/x86/amd/pmc: Add PMFW command id to support S2D force flush Shyam Sundar S K
2023-09-10 14:20 ` [PATCH v4 2/2] platform/x86/amd/pmc: Add dump_custom_stb module parameter Shyam Sundar S K
2023-09-18 12:27 ` Hans de Goede
2023-09-25 10:48 ` Shyam Sundar S K
2023-10-04 9:14 ` Hans de Goede
2023-10-04 12:11 ` Shyam Sundar S K
2023-10-04 15:10 ` Hans de Goede [this message]
2023-10-05 10:15 ` Ilpo Järvinen
2023-10-05 10:51 ` Hans de Goede
2023-10-06 10:27 ` Ilpo Järvinen
2023-10-09 5:57 ` Shyam Sundar S K
2023-10-09 9:25 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47babe3e-052f-d816-9789-5c8ae4728e78@redhat.com \
--to=hdegoede@redhat.com \
--cc=Harsh.Jain@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.