From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90EE22D6409 for ; Wed, 25 Feb 2026 06:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.224.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772000894; cv=none; b=HEsurwi7sI6ei+jSdR1jal0h59TI3dlWcivdaibepXACTgm1WEOhI50B5WQrYZ6DGZq/GKrwpKaNllr58z0HMjxF5G7q9gRJ+COqBXhpaAaA2P67wgh34aLjFnr9Xntp43SNw9ixg+yjOC3eVqTVSnBYyCDEjKvWxGcu86BEj9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772000894; c=relaxed/simple; bh=tMN41zGz7UeUWM6X6nDR04BMWm/g78pRAi1srjgi0V4=; h=MIME-Version:Content-Type:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID; b=DOyHggOT/hQshmH+RFCg3rs5KH2t9O1ZEvc4gAtl6ZJBl4T8E+M1ZFiHuB7cyHBW0qTmKvG358kFuazYLZQI+nG+zO0C6ss77xjr8t0nFn1IrBqLK9F2xrkWhovOxIF5LappU0jAg17584jilvKv9qwRbBhXqoDn7rTG4DtDSMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=lv8C+9C7; arc=none smtp.client-ip=91.198.224.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="lv8C+9C7" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1vv8NE-00G78A-Uk; Wed, 25 Feb 2026 07:27:53 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vv8NE-00DF4U-3F; Wed, 25 Feb 2026 07:27:52 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1772000871; bh=jVEfTq3aS5T/mXtagGtn2FdjhFykhrbkaJ9xFAwbPrk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lv8C+9C76Hs3BQaySwgjvX735FJx1Rq7XysmKpQBSTgQiAATvssrBltwrG3WZ7mYG jR3QNpClGqAlGEcMSpobVNrS1WdvTvfTvjwipscVeqZzbzufXJEC/ySGNKfQMdbgCw WZlqskFj0yKYn20e0m0GRpRc/MVQLloAHB7oxICNlEKjSy3mqnBNx46XO4t0n7GFL3 y4Doygclinbt4Ef5xhMNqvwSm313diqTVjU7m8I6maTK1DmirRBnCHXwQmf6va3/iO k/jUddtfTJc50ZEuy7wvPMdohRxXyqwPQV1zQRTrefGvCBQsVFk9PU9UEzf6aNpu/W zNn9IrHGxQPfw== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 89DB5240040; Wed, 25 Feb 2026 07:27:51 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 826F5240036; Wed, 25 Feb 2026 07:27:51 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 471722300D; Wed, 25 Feb 2026 07:27:51 +0100 (CET) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 25 Feb 2026 07:27:51 +0100 From: Martin Schiller To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, Florian Eckert Subject: Re: [PATCH] x86/reboot: Add call to do_kernel_restart() Organization: TDT AG In-Reply-To: <20260225053254.GBaZ6Jhh-X8Mp5l9eS@renoirsky.local> References: <20260220-x86_do_kernel_restart-v1-1-a0cee49bbc80@dev.tdt.de> <20260225053254.GBaZ6Jhh-X8Mp5l9eS@renoirsky.local> Message-ID: <47d501dae62ff2b85ae225d597b33253@dev.tdt.de> X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 X-purgate-ID: 151534::1772000872-FB4C4F66-D20AF92D/0/0 X-purgate-type: clean X-purgate: clean On 2026-02-25 06:32, Borislav Petkov wrote: > On Fri, Feb 20, 2026 at 01:29:01PM +0100, Martin Schiller wrote: >> SoC devices like the Intel / MaxLinear Lightning Mountain must be >> reset >> by the RCU instead of using "normal" x86 mechanisms like ACPI, BIOS, > > Read-Copy-Update? Sorry, I forgot to explain the abbreviation. RCU is short for Reset Control Unit. That's what it's called in the Intel / MaxLinear world. > > I'm relatively sure you don't mean that. > >> KBD, etc. >> >> Therefore, the RCU driver (reset-intel-gw) registers a restart handler >> which triggers the global reset signal. >> >> Unfortunately, this is of no use as long as the restart chain is not >> processed during reboot on x86 systems. >> >> So we must call do_kernel_restart() when a reboot is performed. This >> has > > Who's "we"? I don't mean anyone in particular. I just wanted to express that the function must be called. > >> long been common practice for other architectures. >> >> Signed-off-by: Martin Schiller >> --- >> arch/x86/kernel/reboot.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c >> index >> 6032fa9ec753ce938b1b523a7eab76370ee802de..ddff25a1efbe71171ca22ec21f50541517c1a464 >> 100644 >> --- a/arch/x86/kernel/reboot.c >> +++ b/arch/x86/kernel/reboot.c >> @@ -773,12 +773,15 @@ static void __machine_emergency_restart(int >> emergency) >> machine_ops.emergency_restart(); >> } >> >> -static void native_machine_restart(char *__unused) >> +static void native_machine_restart(char *command) >> { >> pr_notice("machine restart\n"); >> >> if (!reboot_force) >> machine_shutdown(); >> + >> + do_kernel_restart(command); > > I guess we can do that - the other arches do it already...