All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Taniya Das <quic_tdas@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
	Imran Shaik <quic_imrashai@quicinc.com>,
	Jagadeesh Kona <quic_jkona@quicinc.com>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Dmitry Baryshkov <lumag@kernel.org>
Subject: Re: [PATCH v8 00/10] Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform
Date: Fri, 25 Apr 2025 07:48:26 +0200	[thread overview]
Message-ID: <47d9c1f4-e521-4e46-ad48-a23228d06fbb@kernel.org> (raw)
In-Reply-To: <dfa2ed59-ba7c-4cb4-ac78-97f3de716b9b@quicinc.com>

On 24/04/2025 18:28, Taniya Das wrote:
> 
> 
> On 4/24/2025 8:59 PM, Krzysztof Kozlowski wrote:
>> On 24/04/2025 13:13, Taniya Das wrote:
>>>
>>>
>>> On 4/24/2025 4:40 PM, Krzysztof Kozlowski wrote:
>>>> On 24/04/2025 11:32, Taniya Das wrote:
>>>>> Add support for multimedia clock controllers on Qualcomm QCS615 platform.
>>>>> Update the defconfig to enable these clock controllers.
>>>>>
>>>>> Global clock controller support
>>>>> https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@quicinc.com/
>>>>>
>>>>> Changes in v8:
>>>>> - Drop the properties which are already covered as part of gcc.yaml [Krzysztof]
>>>>> - Drop the RB tag for dt-bindings for Camera clock controller.
>>>>
>>>> Why?
>>>
>>> It had comments, so wanted to share the latest RB-by.
>> So there were some comments and that's the basis to ask to do review
>> twice? So anyone can comment on anything and you will remove people's
>> review? I am not going through this again.
>>
> 
> It was your comments, so I thought it would not be good to keep the RB
> tag if it has so many comments. That was the reason to drop it.
I was fine with the binding, then I gave some comments on other
bindings, you implemented these comments and you claim that result:

	code already reviewed by me + implemented my comments

could be something I would not consider reviewed. Basically

	my review + implemented my comments != my review

I think it means I would be very inconsequential and unpredictable. I
think this is creating unnecessary workload on me, but sure, if that was
the intention I will do the work again.

Best regards,
Krzysztof


      reply	other threads:[~2025-04-25  5:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24  9:32 [PATCH v8 00/10] Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform Taniya Das
2025-04-24  9:32 ` [PATCH v8 01/10] clk: qcom: clk-alpha-pll: Add support for dynamic update for slewing PLLs Taniya Das
2025-04-24  9:32 ` [PATCH v8 02/10] dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller Taniya Das
2025-04-25  5:49   ` Krzysztof Kozlowski
2025-04-28 13:08   ` Vladimir Zapolskiy
2025-06-10  9:23     ` Taniya Das
2025-04-24  9:32 ` [PATCH v8 03/10] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver Taniya Das
2025-04-24  9:32 ` [PATCH v8 04/10] dt-bindings: clock: Add Qualcomm QCS615 Display clock controller Taniya Das
2025-04-24 15:32   ` Krzysztof Kozlowski
2025-04-24  9:33 ` [PATCH v8 05/10] clk: qcom: dispcc-qcs615: Add QCS615 display clock controller driver Taniya Das
2025-04-24  9:33 ` [PATCH v8 06/10] dt-bindings: clock: Add Qualcomm QCS615 Graphics clock controller Taniya Das
2025-04-24 15:31   ` Krzysztof Kozlowski
2025-04-24  9:33 ` [PATCH v8 07/10] clk: qcom: gpucc-qcs615: Add QCS615 graphics clock controller driver Taniya Das
2025-04-24  9:33 ` [PATCH v8 08/10] dt-bindings: clock: Add Qualcomm QCS615 Video clock controller Taniya Das
2025-04-24 15:31   ` Krzysztof Kozlowski
2025-04-24  9:33 ` [PATCH v8 09/10] clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver Taniya Das
2025-04-24  9:33 ` [PATCH v8 10/10] arm64: defconfig: Enable QCS615 clock controllers Taniya Das
2025-04-24 10:18   ` Dmitry Baryshkov
2025-04-24 11:10 ` [PATCH v8 00/10] Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform Krzysztof Kozlowski
2025-04-24 11:13   ` Taniya Das
2025-04-24 15:29     ` Krzysztof Kozlowski
2025-04-24 16:28       ` Taniya Das
2025-04-25  5:48         ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47d9c1f4-e521-4e46-ad48-a23228d06fbb@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.