From: Jens Axboe <axboe@kernel.dk>
To: Dongli Zhang <dongli.zhang@oracle.com>,
linux-scsi@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org
Cc: mst@redhat.com, jasowang@redhat.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, cohuck@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Limit number of hw queues by nr_cpu_ids for virtio-blk and virtio-scsi
Date: Wed, 10 Apr 2019 08:18:50 -0600 [thread overview]
Message-ID: <47e8d8bf-1820-5cb4-ac78-1bcd5ea26c49@kernel.dk> (raw)
In-Reply-To: <1553682995-5682-1-git-send-email-dongli.zhang@oracle.com>
On 3/27/19 4:36 AM, Dongli Zhang wrote:
> When tag_set->nr_maps is 1, the block layer limits the number of hw queues
> by nr_cpu_ids. No matter how many hw queues are use by
> virtio-blk/virtio-scsi, as they both have (tag_set->nr_maps == 1), they
> can use at most nr_cpu_ids hw queues.
>
> In addition, specifically for pci scenario, when the 'num-queues' specified
> by qemu is more than maxcpus, virtio-blk/virtio-scsi would not be able to
> allocate more than maxcpus vectors in order to have a vector for each
> queue. As a result, they fall back into MSI-X with one vector for config
> and one shared for queues.
>
> Considering above reasons, this patch set limits the number of hw queues
> used by nr_cpu_ids for both virtio-blk and virtio-scsi.
I picked both up for 5.1.
--
Jens Axboe
prev parent reply other threads:[~2019-04-10 14:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 10:36 [PATCH 0/2] Limit number of hw queues by nr_cpu_ids for virtio-blk and virtio-scsi Dongli Zhang
2019-03-27 10:36 ` Dongli Zhang
2019-03-27 10:36 ` [PATCH 1/2] virtio-blk: limit number of hw queues by nr_cpu_ids Dongli Zhang
2019-04-10 13:12 ` Stefan Hajnoczi
2019-04-10 13:12 ` Stefan Hajnoczi
2019-03-27 10:36 ` Dongli Zhang
2019-03-27 10:36 ` [PATCH 2/2] scsi: virtio_scsi: " Dongli Zhang
2019-03-27 10:36 ` Dongli Zhang
2019-04-10 13:12 ` Stefan Hajnoczi
2019-04-10 13:12 ` Stefan Hajnoczi
2019-04-08 13:57 ` [PATCH 0/2] Limit number of hw queues by nr_cpu_ids for virtio-blk and virtio-scsi Dongli Zhang
2019-04-08 13:57 ` Dongli Zhang
2019-04-10 14:18 ` Jens Axboe
2019-04-10 14:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47e8d8bf-1820-5cb4-ac78-1bcd5ea26c49@kernel.dk \
--to=axboe@kernel.dk \
--cc=cohuck@redhat.com \
--cc=dongli.zhang@oracle.com \
--cc=jasowang@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.