From: Christian Loehle <christian.loehle@arm.com>
To: Pengjie Zhang <zhangpengjie2@huawei.com>,
rafael@kernel.org, viresh.kumar@linaro.org
Cc: linuxarm@huawei.com, zhanjie9@hisilicon.com,
prime.zeng@hisilicon.com, wanghuiqiang@huawei.com,
xuwei5@huawei.com, zhenglifeng1@huawei.com, yubowen8@huawei.com,
pierre.gondois@arm.com, sumitg@nvidia.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
mojunjun4@huawei.com
Subject: Re: [PATCH v3] cpufreq: CPPC: Enable boost by default
Date: Tue, 17 Nov 2026 11:06:28 +0000 [thread overview]
Message-ID: <47ef2005-97ff-4841-8a87-5093323e1914@arm.com> (raw)
In-Reply-To: <20261117105240.1113405-1-zhangpengjie2@huawei.com>
On 11/17/26 10:52, Pengjie Zhang wrote:
> The CPPC driver leaves boost disabled by default when Highest Performance
> exceeds Nominal Performance. Userspace must explicitly enable boost
> before governors can use the full advertised performance range.
>
> For user convenience, set .boost_enabled = true in cppc_cpufreq_driver.
> Since cppc_cpufreq_cpu_init() sets policy->boost_supported when
> highest_perf > nominal_perf, the cpufreq core will enable boost by
> default only for policies that support it.
>
> Signed-off-by: Pengjie Zhang <zhangpengjie2@huawei.com>
Reviewed-by: Christian Loehle <christian.loehle@arm.com>
That being said it doesn't apply cleanly on bleeding-edge, so you might
wanna rebase to make Rafael's life a little easier.
> ---
> Changes in v3:
> - Drop cppc_cpufreq_default_boost_init() and set .boost_enabled = true
> statically in cppc_cpufreq_driver (Christian).
> - Link to v2: https://lore.kernel.org/all/20261022075901.3436021-1-zhangpengjie2@huawei.com/
>
> Changes in v2:
> - Drop "even" from the commit message (Christian).
> - Link to v1: https://lore.kernel.org/all/20261015015812.867988-1-zhangpengjie2@huawei.com/
> ---
> drivers/cpufreq/cppc_cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 957fa7775260..1ea16e95c0e9 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -1059,6 +1059,7 @@ static struct cpufreq_driver cppc_cpufreq_driver = {
> .fast_switch = cppc_cpufreq_fast_switch,
> .init = cppc_cpufreq_cpu_init,
> .exit = cppc_cpufreq_cpu_exit,
> + .boost_enabled = true,
> .set_boost = cppc_cpufreq_set_boost,
> .attr = cppc_cpufreq_attr,
> .name = "cppc_cpufreq",
next prev parent reply other threads:[~2026-11-17 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:52 [PATCH v3] cpufreq: CPPC: Enable boost by default Pengjie Zhang
2026-11-17 11:06 ` Christian Loehle [this message]
2026-11-17 11:54 ` Pengjie Zhang
2026-11-17 12:21 ` Pengjie Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ef2005-97ff-4841-8a87-5093323e1914@arm.com \
--to=christian.loehle@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mojunjun4@huawei.com \
--cc=pierre.gondois@arm.com \
--cc=prime.zeng@hisilicon.com \
--cc=rafael@kernel.org \
--cc=sumitg@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=wanghuiqiang@huawei.com \
--cc=xuwei5@huawei.com \
--cc=yubowen8@huawei.com \
--cc=zhangpengjie2@huawei.com \
--cc=zhanjie9@hisilicon.com \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.