From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: npiggin@gmail.com
Subject: Re: [PATCH] powerpc/mm: Mark get_slice_psize() & slice_addr_is_low() as notrace
Date: Mon, 6 Jan 2020 16:23:21 +1100 (AEDT) [thread overview]
Message-ID: <47rkSB1FVLz9sR1@ozlabs.org> (raw)
In-Reply-To: <20191221121337.4894-1-mpe@ellerman.id.au>
On Sat, 2019-12-21 at 12:13:37 UTC, Michael Ellerman wrote:
> These slice routines are called from the SLB miss handler, which can
> lead to warnings from the IRQ code, because we have not reconciled the
> IRQ state properly:
>
> WARNING: CPU: 72 PID: 30150 at arch/powerpc/kernel/irq.c:258 arch_local_irq_restore.part.0+0xcc/0x100
> Modules linked in:
> CPU: 72 PID: 30150 Comm: ftracetest Not tainted 5.5.0-rc2-gcc9x-g7e0165b2f1a9 #1
> NIP: c00000000001d83c LR: c00000000029ab90 CTR: c00000000026cf90
> REGS: c0000007eee3b960 TRAP: 0700 Not tainted (5.5.0-rc2-gcc9x-g7e0165b2f1a9)
> MSR: 8000000000021033 <SF,ME,IR,DR,RI,LE> CR: 22242844 XER: 20000000
> CFAR: c00000000001d780 IRQMASK: 0
> ...
> NIP arch_local_irq_restore.part.0+0xcc/0x100
> LR trace_graph_entry+0x270/0x340
> Call Trace:
> trace_graph_entry+0x254/0x340 (unreliable)
> function_graph_enter+0xe4/0x1a0
> prepare_ftrace_return+0xa0/0x130
> ftrace_graph_caller+0x44/0x94 # (get_slice_psize())
> slb_allocate_user+0x7c/0x100
> do_slb_fault+0xf8/0x300
> instruction_access_slb_common+0x140/0x180
>
> Fixes: 48e7b7695745 ("powerpc/64s/hash: Convert SLB miss handlers to C")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc fixes.
https://git.kernel.org/powerpc/c/91a063c956084fb21cf2523bce6892514e3f1799
cheers
prev parent reply other threads:[~2020-01-06 5:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 12:13 [PATCH] powerpc/mm: Mark get_slice_psize() & slice_addr_is_low() as notrace Michael Ellerman
2020-01-06 5:23 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47rkSB1FVLz9sR1@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.