All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, aabdulla@nvidia.com, yhlu.kernel@gmail.com
Subject: Re: [patch for 2.6.25? 1/3] forcedeth: mac address fix
Date: Sat, 12 Apr 2008 04:42:32 -0400	[thread overview]
Message-ID: <480075F8.4050801@garzik.org> (raw)
In-Reply-To: <200804110430.m3B4UZ5C000433@imap1.linux-foundation.org>

akpm@linux-foundation.org wrote:
> From: Ayaz Abdulla <aabdulla@nvidia.com>
> 
> This critical patch fixes a mac address issue recently introduced.  If the
> device's mac address was in correct order and the flag
> NVREG_TRANSMITPOLL_MAC_ADDR_REV was set, during nv_remove the flag would get
> cleared.  During next load, the mac address would get reversed because the
> flag is missing.
> 
> As it has been indicated previously, the flag is cleared across a low power
> transition.  Therefore, the driver should set the mac address back into the
> reversed order when clearing the flag.
> 
> Also, the driver should set back the flag after a low power transition to
> protect against kexec command calling nv_probe a second time.
> 
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
> Cc: "Yinghai Lu" <yhlu.kernel@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/net/forcedeth.c |   26 ++++++++++++++++++++++++--
>  1 file changed, 24 insertions(+), 2 deletions(-)

applied



  reply	other threads:[~2008-04-12  8:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11  4:30 [patch for 2.6.25? 1/3] forcedeth: mac address fix akpm
2008-04-12  8:42 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-09  0:31 akpm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480075F8.4050801@garzik.org \
    --to=jeff@garzik.org \
    --cc=aabdulla@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.