From: Jeff Garzik <jeff@garzik.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sb1000.c: stop inlining largish static functions
Date: Sat, 12 Apr 2008 05:08:16 -0400 [thread overview]
Message-ID: <48007C00.7070100@garzik.org> (raw)
In-Reply-To: <200803310102.43277.vda.linux@googlemail.com>
Denys Vlasenko wrote:
> Hi Jeff,
>
> Can you take this patch into your net driver fixes tree?
>
> drivers/net/sb1000.c has lots of inlined static functions.
>
> Mst of them are used at initialization, wait for some
> hardware register to change (wait using yield, sleep etc),
> or do slow port-based I/O. Inlining thse "for speed" makes no sense.
>
> This patch removes "inline" from biggest static function
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
>
> Size difference for 32bit x86:
>
> text data bss dec hex filename
> 6299 129 0 6428 191c linux-2.6-ALLYES/drivers/net/sb1000.o
> 5418 129 0 5547 15ab linux-2.6.inline-ALLYES/drivers/net/sb1000.o
>
> (I also see some other optimization opportunities,
> will test and send a patch separately).
>
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
applied both patches
prev parent reply other threads:[~2008-04-12 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-30 23:02 [PATCH] sb1000.c: stop inlining largish static functions Denys Vlasenko
2008-03-30 23:13 ` [PATCH] sb1000.c: make const arrays static Denys Vlasenko
2008-04-12 9:08 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48007C00.7070100@garzik.org \
--to=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.