From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.xyz (Icenowy Zheng) Date: Sun, 31 Jul 2016 21:18:12 +0800 Subject: [PATCH 2/3] phy: sun4i: add support for A64 usb phy In-Reply-To: References: <20160731112536.4625-1-icenowy@aosc.xyz> <20160731112536.4625-2-icenowy@aosc.xyz> Message-ID: <48021469971092@web25g.yandex.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 31.07.2016, 20:39, "Amit Tomer" : > Hello , > >> ?@@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy) >> ?????????????????val = readl(phy->pmu + REG_PMU_UNK_H3); >> ?????????????????writel(val & ~2, phy->pmu + REG_PMU_UNK_H3); >> ?????????} else { >> ?+ /* A64 needs also this unknown bit */ >> ?+ if (data->cfg->type == sun50i_a64_phy) { >> ?+ val = readl(phy->pmu + REG_PMU_UNK_H3); >> ?+ writel(val & ~2, phy->pmu + REG_PMU_UNK_H3); >> ?+ } >> ?+ > > This bit is also set for H3, shall we reuse it or we should enclose it > in else-if part ? To be honest, I don't know which format is better... I'm not so familiar about the tradition of Linux kernel coding style... > > Thanks > Amit. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy Date: Sun, 31 Jul 2016 21:18:12 +0800 Message-ID: <48021469971092@web25g.yandex.ru> References: <20160731112536.4625-1-icenowy@aosc.xyz> <20160731112536.4625-2-icenowy@aosc.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Amit Tomer Cc: Mark Rutland , "devicetree@vger.kernel.org" , Reinder de Haan , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kishon Vijay Abraham I , Tony Prisk , Hans de Goede , Chen-Yu Tsai , Rob Herring , Alan Stern , Maxime Ripard , linux-arm-kernel List-Id: devicetree@vger.kernel.org CgozMS4wNy4yMDE2LCAyMDozOSwgIkFtaXQgVG9tZXIiIDxhbWl0dG9tZXIyNUBnbWFpbC5jb20+ Ogo+IEhlbGxvICwKPgo+PiDCoEBAIC0yNjQsNiArMjY2LDEyIEBAIHN0YXRpYyBpbnQgc3VuNGlf dXNiX3BoeV9pbml0KHN0cnVjdCBwaHkgKl9waHkpCj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqB2YWwgPSByZWFkbChwaHktPnBtdSArIFJFR19QTVVfVU5LX0gzKTsKPj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHdyaXRlbCh2YWwgJiB+MiwgcGh5LT5wbXUg KyBSRUdfUE1VX1VOS19IMyk7Cj4+IMKgwqDCoMKgwqDCoMKgwqDCoH0gZWxzZSB7Cj4+IMKgKyAv KiBBNjQgbmVlZHMgYWxzbyB0aGlzIHVua25vd24gYml0ICovCj4+IMKgKyBpZiAoZGF0YS0+Y2Zn LT50eXBlID09IHN1bjUwaV9hNjRfcGh5KSB7Cj4+IMKgKyB2YWwgPSByZWFkbChwaHktPnBtdSAr IFJFR19QTVVfVU5LX0gzKTsKPj4gwqArIHdyaXRlbCh2YWwgJiB+MiwgcGh5LT5wbXUgKyBSRUdf UE1VX1VOS19IMyk7Cj4+IMKgKyB9Cj4+IMKgKwo+Cj4gVGhpcyBiaXQgaXMgYWxzbyBzZXQgZm9y IEgzLCBzaGFsbCB3ZSByZXVzZSBpdCBvciB3ZSBzaG91bGQgZW5jbG9zZSBpdAo+IGluIGVsc2Ut aWYgcGFydCA/ClRvIGJlIGhvbmVzdCwgSSBkb24ndCBrbm93IHdoaWNoIGZvcm1hdCBpcyBiZXR0 ZXIuLi4KSSdtIG5vdCBzbyBmYW1pbGlhciBhYm91dCB0aGUgdHJhZGl0aW9uIG9mIExpbnV4IGtl cm5lbCBjb2Rpbmcgc3R5bGUuLi4KPgo+IFRoYW5rcwo+IEFtaXQuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==