Re: [patch] xfsqa - 166 - fix filter for stripe aligned filesystems

[Eric Sandeen <sandeen@sandeen.net>]

Niv Sardi wrote:
> Looks good, one minor comment.
> 
> David Chinner <dgc@sgi.com> writes:
> 
>> Flags has extra bits set in it xfs_bmap output when
>> the filesyste is using stripe alignment. Fix the test
>> to only look at the unwritten flag. Capture the xfs_bmap
>> output as well so failures can be debugged easily.
>>
>> Signed-off-by: Dave Chinner <dgc@sgi.com>
>> ---
>>  xfstests/166 |   17 ++++++++++-------
>>  1 file changed, 10 insertions(+), 7 deletions(-)
>>
>> Index: xfs-cmds/xfstests/166
>> ===================================================================
>> --- xfs-cmds.orig/xfstests/166	2008-03-25 15:29:35.000000000 +1100
>> +++ xfs-cmds/xfstests/166	2008-04-11 13:33:31.220068950 +1000
>> @@ -17,6 +17,7 @@ here=`pwd`
>>  tmp=/tmp/$$
>>  status=1    # failure is the default!
>>  trap "_cleanup; exit \$status" 0 1 2 3 15
>> +rm $seq.full
> 
> rm -f ? so that it doesn't complain when file is not there ?

All other tests do use rm -f here, it seems.

-Eric