From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Date: Mon, 14 Apr 2008 15:31:54 +0000 Subject: Re: [kvm-ppc-devel] [PATCH] [3/3] kvmppc: make tlb tracing Message-Id: <480378EA.70008@linux.vnet.ibm.com> List-Id: References: <200804141639.30920.arnd@arndb.de> In-Reply-To: <200804141639.30920.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: kvm-ppc@vger.kernel.org Arnd Bergmann wrote: > On Monday 14 April 2008, ehrhardt@linux.vnet.ibm.com wrote: >> @@ -58,6 +58,14 @@ config KVM_POWERPC_440_TRACE_INSTRUCTION >> channel. >> If unsure, say N. >> =20 >> +config KVM_POWERPC_440_TRACE_TLB >> + bool "ppc440 guest tlb activity tracing" >> + depends on KVM && 44x && KVM_POWERPC_440 >> + select RELAY >> + ---help--- >> + Adds the complete tracing of the tlb activities via a relayfs = channel. >> + If unsure, say N. >> + >=20 > I think you're taking the configurability a little too far, do you really > want users to be able to select the three new tracing options separately? > Choosing between all stats and no stats at all sounds sufficient to me. >=20 > Arnd <>< hmmm ... I intended it exaclty to be that selectable to save runtime overhe= ad because e.g. the relay code add overhead all the time. We might think of enabling them at runtime, but since all are developer too= ls I would prefer the .config way. E.g. If I want to low overhead profile instructions so I would only enable = KVM_POWERPC_440_INSTRUCTION_STAT and none of the others. Actually that's the only reason the kvm_stat version exists,= because the instruction tracing has the same info + much more just with mo= re overhead. btw - I already think of removing the kvm_stat variant, because the relay b= ased tracing revealed to be not as overhead bound as I thought. --=20 Gr=FCsse / regards,=20 Christian Ehrhardt IBM Linux Technology Center, Open Virtualization ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference=20 Don't miss this year's exciting event. There's still time to save $100.=20 Use priority code J8TL2D2.=20 http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/java= one _______________________________________________ kvm-ppc-devel mailing list kvm-ppc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel