[Qemu-devel] Re: [PATCH 2/2] 8250: Customized base baudrate

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

andrzej zaborowski wrote:
> On 13/04/2008, Jan Kiszka <jan.kiszka@web.de> wrote:
>>  --- a/hw/omap1.c
>>  +++ b/hw/omap1.c
>>  @@ -1734,7 +1734,8 @@ struct omap_uart_s *omap_uart_init(targe
>>      struct omap_uart_s *s = (struct omap_uart_s *)
>>              qemu_mallocz(sizeof(struct omap_uart_s));
>>      if (chr)
>>  -        s->serial = serial_mm_init(base, 2, irq, chr, 1);
>>  +        s->serial =
>>  +            serial_mm_init(base, 2, irq, omap_clk_getrate(clk)/16, chr, 1);
> 
> Yes, this should be correct.

While typing those line I wondered if it is possible and reasonable that
a guest changes this clock rate during runtime? In that case, the
perfect, but probably much more complex solution would be to track those
changes also with the serial emulation...

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]