From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH 1/2] Don't panic if a controller driver does ecc its own way.
Date: Mon, 14 Apr 2008 14:55:24 -0500 [thread overview]
Message-ID: <4803B6AC.50603@freescale.com> (raw)
In-Reply-To: <20080414195050.0DC4B248B9@gemini.denx.de>
Wolfgang Denk wrote:
> In message <20080414163455.GA7061@ld0162-tx32.am.freescale.net> you wrote:
>>>> Some hardware, such as the enhanced local bus controller used on some
>>>> mpc83xx chips, does ecc transparently when reading and writing data, rather
>>>> than providing a generic calculate/correct mechanism that can be exported to
>>>> the nand subsystem.
>>>>
>>>> The subsystem should not BUG() when calculate, correct, or hwctl are
>>>> missing, if the methods that call them have been overridden.
>>>>
>>>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>>> This should go through the 83xx custodian, but I haven't seen this
>>> yet?
>> Why should it go through 83xx? It's a patch against generic NAND code.
>
> It seems to be 83xx specific code to me?
It's not. It is removing a restriction in the NAND code that happens to
interfere with what the FSL NAND driver needs to do.
>> Did you try applying it against the 2.6.22.1 branch of the nand
>> repository (IIRC, the non-commit-message patch comment specified that)?
>
> No, I tried to apply this to the U-Boot repository. Maybe this was my
> fault? Is this supposed to go into Linux, then?
No, it's supposed to go into the 2.6.22.1 branch of Stefan's u-boot NAND
tree. This change is already in the Linux NAND code.
-Scott
next prev parent reply other threads:[~2008-04-14 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 17:53 [U-Boot-Users] [PATCH 1/2] Don't panic if a controller driver does ecc its own way Scott Wood
2008-04-13 22:01 ` Wolfgang Denk
2008-04-14 16:34 ` Scott Wood
2008-04-14 19:50 ` Wolfgang Denk
2008-04-14 19:55 ` Scott Wood [this message]
2008-04-15 4:35 ` Wolfgang Denk
2008-04-18 15:08 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4803B6AC.50603@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.