All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Scally <djrscally@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: Fix inconsistent indenting
Date: Thu, 2 Dec 2021 09:47:59 +0000	[thread overview]
Message-ID: <4803fe17-fdce-dbcc-99e7-29e0715dfee9@gmail.com> (raw)
In-Reply-To: <1638434358-47417-1-git-send-email-jiapeng.chong@linux.alibaba.com>

Hi Jiapeng


Thanks for catching that

On 02/12/2021 08:39, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/media/i2c/ov8865.c:2841 ov8865_get_selection() warn:
> inconsistent indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>


Reviewed-by: Daniel Scally <djrscally@gmail.com>

> ---
>  drivers/media/i2c/ov8865.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
> index ebdb20d..09ba13f 100644
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -2836,8 +2836,7 @@ static int ov8865_get_selection(struct v4l2_subdev *subdev,
>  	switch (sel->target) {
>  	case V4L2_SEL_TGT_CROP:
>  		mutex_lock(&sensor->mutex);
> -			__ov8865_get_pad_crop(sensor, state, sel->pad,
> -					      sel->which, &sel->r);
> +		__ov8865_get_pad_crop(sensor, state, sel->pad, sel->which, &sel->r);
>  		mutex_unlock(&sensor->mutex);
>  		break;
>  	case V4L2_SEL_TGT_NATIVE_SIZE:

      reply	other threads:[~2021-12-02  9:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  8:39 [PATCH] media: i2c: Fix inconsistent indenting Jiapeng Chong
2021-12-02  9:47 ` Daniel Scally [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4803fe17-fdce-dbcc-99e7-29e0715dfee9@gmail.com \
    --to=djrscally@gmail.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.