From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Starikovskiy Subject: Re: [PATCH 65/73] ACPICA: Fix for extraneous debug message for packages Date: Tue, 15 Apr 2008 22:56:42 +0400 Message-ID: <4804FA6A.2050401@suse.de> References: <1207974356-30687-1-git-send-email-lenb@kernel.org> <200804150309.25361.lenb@kernel.org> <48046902.8040900@gmail.com> <9D39833986E69849A2A8E74C1078B6B3257A97@orsmsx415.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from charybdis-ext.suse.de ([195.135.221.2]:35828 "EHLO emea5-mh.id5.novell.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752765AbYDOS4w (ORCPT ); Tue, 15 Apr 2008 14:56:52 -0400 In-Reply-To: <9D39833986E69849A2A8E74C1078B6B3257A97@orsmsx415.amr.corp.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Moore, Robert" Cc: Alexey Starikovskiy , Len Brown , linux-acpi@vger.kernel.org Moore, Robert wrote: > We use acpi_native_uint for things like array indexes so it goes 32/64 > without warnings (lint or otherwise). > > However, > typedef UINT32 ACPI_NATIVE_UINT; > > should get converted to > typedef u32 acpi_native_uint; Well, "unsigned int" is supposed to be of native length. u32 is not going to be of native length on 64 bits. What kind of warning do you avoid? I don't know any checker who does not accept int/unsigned int as array index... Regards, Alex. > > during the linuxiztion, I think > >> -----Original Message----- >> From: Alexey Starikovskiy [mailto:aystarik@gmail.com] >> Sent: Tuesday, April 15, 2008 1:36 AM >> To: Len Brown >> Cc: linux-acpi@vger.kernel.org; Moore, Robert; Alexey Starikovskiy >> Subject: Re: [PATCH 65/73] ACPICA: Fix for extraneous debug message for >> packages >> >> Len Brown wrote: >>> From: Len Brown >>> >>> drivers/acpi/dispatcher/dsobject.c:499: warning: format '%X' expects > type >> 'unsigned int', but argument 4 has type 'acpi_native_uint' >>> drivers/acpi/dispatcher/dsobject.c:507: warning: format '%X' expects > type >> 'unsigned int', but argument 7 has type 'acpi_native_uint' >>> Signed-off-by: Len Brown >>> --- >>> drivers/acpi/dispatcher/dsobject.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/acpi/dispatcher/dsobject.c >> b/drivers/acpi/dispatcher/dsobject.c >>> index 5184278..bdef2f0 100644 >>> --- a/drivers/acpi/dispatcher/dsobject.c >>> +++ b/drivers/acpi/dispatcher/dsobject.c >>> @@ -373,7 +373,7 @@ acpi_ds_build_internal_package_obj(struct >> acpi_walk_state *walk_state, >>> union acpi_parse_object *parent; >>> union acpi_operand_object *obj_desc = NULL; >>> acpi_status status = AE_OK; >>> - acpi_native_uint i; >>> + u32 i; >>> >> why not just unsigned ? >>> u16 index; >>> u16 reference_count; >>> >>> >