From: Roel Kluin <12o3l@tiscali.nl>
To: bzolnier@gmail.com
Cc: linux-ide@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/6] IDE: ide-cd: fix test unsigned var < 0
Date: Wed, 16 Apr 2008 04:06:18 +0200 [thread overview]
Message-ID: <48055F1A.9020706@tiscali.nl> (raw)
Is this the right fix in this case?
---
valid is unsigned and cannot be below 0.,
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index c8d0e87..a60f5df 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -182,8 +182,6 @@ void cdrom_analyze_sense_data(ide_drive_t *drive,
sector &= ~(bio_sectors -1);
valid = (sector - failed_command->sector) << 9;
- if (valid < 0)
- valid = 0;
if (sector < get_capacity(info->disk) &&
drive->probed_capacity - sector < 4 * 75) {
set_capacity(info->disk, sector);
next reply other threads:[~2008-04-16 2:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 2:06 Roel Kluin [this message]
2008-04-16 22:40 ` [PATCH 3/6] IDE: ide-cd: fix test unsigned var < 0 Bartlomiej Zolnierkiewicz
2008-04-17 3:51 ` Roel Kluin
2008-04-17 9:12 ` Boris Petkov
2008-04-17 11:04 ` Roel Kluin
2008-04-17 12:01 ` Boris Petkov
2008-04-27 18:32 ` Bartlomiej Zolnierkiewicz
2008-04-27 18:32 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48055F1A.9020706@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.