From: Andi Kleen <andi@firstfloor.org>
To: David Miller <davem@davemloft.net>
Cc: vgusev@openvz.org, kuznet@ms2.inr.ac.ru, netdev@vger.kernel.org
Subject: Re: [PATCH] Discard tcp out-of-order queue if system limit is reached
Date: Wed, 16 Apr 2008 09:01:45 +0200 [thread overview]
Message-ID: <4805A459.5050706@firstfloor.org> (raw)
In-Reply-To: <20080415.202740.114756353.davem@davemloft.net>
David Miller wrote:
> From: Vitaliy Gusev <vgusev@openvz.org>
> Date: Tue, 15 Apr 2008 18:54:44 +0400
>
>> tcp_prune_queue() doesn't prune an out-of-order queue if socket
>> is under rcvbuf. However even if socket is under rcvbuf but system-wide limit is
>> reached then skb cannot be queued. It can lead to deadlock situation as any skb that
>> fills sequence hole is dropped.
>> So discard out-of-order queue if system-wide limit is reached.
>>
>> Signed-off-by: Vitaliy Gusev <vgusev@openvz.org>
>
> I applied your original patch already, so I added the following
> relative patch.
Could you please at least update the original description to the
one from the new patch? That one was somewhat misleading imho.
-Andi
next prev parent reply other threads:[~2008-04-16 7:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 14:54 [PATCH] Discard tcp out-of-order queue if system limit is reached Vitaliy Gusev
2008-04-15 14:58 ` Andi Kleen
2008-04-15 15:22 ` Stephen Hemminger
2008-04-16 3:27 ` David Miller
2008-04-16 7:01 ` Andi Kleen [this message]
2008-04-16 7:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4805A459.5050706@firstfloor.org \
--to=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=vgusev@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.