All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avinesh Kumar <akumar@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)
Date: Mon, 06 Feb 2023 16:06:39 +0530	[thread overview]
Message-ID: <4806953.31r3eYUQgx@localhost> (raw)
In-Reply-To: <20230206061001.13164-1-pvorel@suse.cz>

Hi,

Reviewed-by: Avinesh Kumar <akumar@suse.de>

On Monday, February 6, 2023 11:40:01 AM IST Petr Vorel wrote:
> -i0 is helpful to test if setup and cleanup are working.
> We suggest that in maintainer-patch-review-checklist.txt.
> 
> Fixes: 4c0465f217 ("lib: Replace atoi/atof with SAFE_STRTOL/SAFE_STRTOF")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  lib/tst_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 23d21c8255..04d6b13bfc 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -678,7 +678,7 @@ static void parse_opts(int argc, char *argv[])
>  			print_test_tags();
>  			exit(0);
>  		case 'i':
> -			iterations = SAFE_STRTOL(optarg, 1, INT_MAX);
> +			iterations = SAFE_STRTOL(optarg, 0, INT_MAX);
>  		break;
>  		case 'I':
>  			if (tst_test->max_runtime > 0)
> 

Regards,
Avinesh



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-02-06 10:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06  6:10 [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0) Petr Vorel
2023-02-06 10:36 ` Avinesh Kumar [this message]
2023-02-06 14:17 ` Jan Stancek
2023-02-06 16:12   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4806953.31r3eYUQgx@localhost \
    --to=akumar@suse.de \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.