From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dvmed.net (srv5.dvmed.net [207.36.208.214]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 58DE4DE02D for ; Thu, 17 Apr 2008 10:54:08 +1000 (EST) Message-ID: <48069FA7.5060207@pobox.com> Date: Wed, 16 Apr 2008 20:53:59 -0400 From: Jeff Garzik MIME-Version: 1.0 To: Sergei Shtylyov Subject: Re: [PATCH] natsemi: fix MMIO for PPC 44x platforms References: <200804122058.31075.sshtylyov@ru.mvista.com> In-Reply-To: <200804122058.31075.sshtylyov@ru.mvista.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sergei Shtylyov wrote: > The driver stores the PCI resource address into 'unsigned long' variable before > calling ioremap() on it. This warrants a kernel oops when the registers are > accessed on PPC 44x platforms which (being 32-bit) have PCI memory space mapped > beyond 4 GB. > > The arch/ppc/ kernel has a fixup in ioremap() that creates an illusion of the > PCI memory resources are mapped below 4 GB, but arch/powerpc/ code got rid of > this trick, having instead CONFIG_RESOURCES_64BIT enabled. > > Signed-off-by: Sergei Shtylyov > > --- > Reposting the patch with the typecast, log, and summary corrected. > This is the same issue as the one that has been recently addressed by commits > 3c34ac36ac1084e571ef9b6fb1d6a5b10ccc1fd0 (e1000: Fix for 32 bits platforms with > 64 bits resources) and c976816b6e901341ec3c4653147316c15549a1c4 (siimage: fix > kernel oops on PPC 44x). The patch has only been compile tested though... > > drivers/net/natsemi.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) applied