All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: netdev@vger.kernel.org, Andy Fleming <afleming@freescale.com>
Subject: Re: [PATCH v2.6.26 2/2] gianfar: Determine TBIPA value dynamically
Date: Wed, 16 Apr 2008 20:55:51 -0400	[thread overview]
Message-ID: <4806A017.4000107@pobox.com> (raw)
In-Reply-To: <1208278162-17462-3-git-send-email-paul.gortmaker@windriver.com>

Paul Gortmaker wrote:
> TBIPA needs to be set to a value (on connected MDIO buses) that doesn't
> conflict with PHYs on the bus.  By hardcoding it to 0x1f, we were preventing
> boards with PHYs at 0x1f from working properly.  Instead, scan the bus when
> it comes up, and find an address that doesn't have a PHY on it.  The TBI PHY
> configuration code then trusts that the value in TBIPA is either safe, or
> doesn't matter (ie - it's not an active bus with other PHYs).
> 
> Signed-off-by: Andy Fleming <afleming@freescale.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/net/gianfar.c     |   27 ++++++++++++++-------------
>  drivers/net/gianfar.h     |    1 -
>  drivers/net/gianfar_mii.c |   38 +++++++++++++++++++++++++++++++++-----
>  drivers/net/gianfar_mii.h |    3 +++
>  4 files changed, 50 insertions(+), 19 deletions(-)

ACK, but failed to apply

please rediff against jgarzik/netdev-2.6.git#upstream or its parent, 
davem/net-2.6.26.git



  reply	other threads:[~2008-04-17  0:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-15 16:49 [PATCH v2.6.26 0/2] Dynamic TBIPA for gianfar Paul Gortmaker
2008-04-15 16:49 ` [PATCH v2.6.26 1/2] phylib: factor out get_phy_id from within get_phy_device Paul Gortmaker
2008-04-15 16:49   ` [PATCH v2.6.26 2/2] gianfar: Determine TBIPA value dynamically Paul Gortmaker
2008-04-17  0:55     ` Jeff Garzik [this message]
2008-04-17  4:08       ` Paul Gortmaker
2008-04-29  6:01         ` Jeff Garzik
2008-04-17  0:55   ` [PATCH v2.6.26 1/2] phylib: factor out get_phy_id from within get_phy_device Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2008-04-15 16:23 [PATCH v2.6.26 0/2] Dynamic TBIPA for gianfar Paul Gortmaker
2008-04-15 16:23 ` [PATCH v2.6.26 1/2] phylib: factor out get_phy_id from within get_phy_device Paul Gortmaker
2008-04-15 16:23   ` [PATCH v2.6.26 2/2] gianfar: Determine TBIPA value dynamically Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4806A017.4000107@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=afleming@freescale.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.