Re: Extboot Option ROM rewritten in C - v3

["H. Peter Anvin" <hpa@zytor.com>]

Nguyen Anh Quynh wrote:
> This patch replaces the current assembly code of Extboot option rom
> with new C code. Patch is against kvm-66.
> 
> This version returns an error code in case int 13 handler cannot
> handle a requested function.
> 
> Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>
> 

+	/* -fomit-frame-pointer might clobber %ebp */
+	pushl %ebp
+	call setup
+	popl  %ebp


No, it might not.  %ebx, %ebp, %esi, and %edi are guaranteed preserved; 
%eax, %ecx and %edx are clobbered.

It's also prudent to call cld before jumping to C code.

	-hpa


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone