From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org,
Stephen Hemminger
<shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 5/6] xen: dont create dependency on cmdline library
Date: Mon, 24 Mar 2014 22:01:05 +0100 [thread overview]
Message-ID: <4807409.VkCA9iV8rJ@xps13> (raw)
In-Reply-To: <20140307181430.240987691-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
07/03/2014 10:13, Stephen Hemminger:
> The driver should not introduce an unnecessary dependency on the cmdline
> code. We don't build that code since it is not used in our product.
Your product is not the concern but I agree this dependency is unnecessary.
I'd just remove the comment about your product.
> +/* defined in <netinet/ether.h> but that has conflicts with rte_ethdev.h */
> +extern struct ether_addr *ether_aton(const char *);
It seems we should fix this conflict first.
I think the problem is about libc redefinitions in rte_ether.h.
Patches are welcome.
--
Thomas
next prev parent reply other threads:[~2014-03-24 21:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 18:13 [PATCH 0/6] DPDK 1.6.1 fixes Stephen Hemminger
2014-03-07 18:13 ` [PATCH 1/6] rte_mbuf: copy offload flags when doing attach/clone of mbuf Stephen Hemminger
[not found] ` <20140307181421.045171437-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-03-24 18:21 ` Thomas Monjalon
2014-03-07 18:13 ` [PATCH 2/6] qos: use rte_zmalloc instead of memzone for allocation Stephen Hemminger
[not found] ` <20140307181423.371047493-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-03-24 18:30 ` Thomas Monjalon
2014-03-07 18:13 ` [PATCH 3/6] rte_jhash: make arg to rte_jhash2 const Stephen Hemminger
[not found] ` <20140307181425.176731410-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-03-24 18:22 ` Thomas Monjalon
2014-03-07 18:13 ` [PATCH 4/6] mempool: use GCC push/pop Stephen Hemminger
[not found] ` <20140307181427.254643901-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-03-24 18:23 ` Thomas Monjalon
2014-03-07 18:13 ` [PATCH 5/6] xen: dont create dependency on cmdline library Stephen Hemminger
[not found] ` <20140307181430.240987691-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-03-24 21:01 ` Thomas Monjalon [this message]
2014-03-07 18:13 ` [PATCH 6/6] ivshmem: fix errors identified by hardening Stephen Hemminger
[not found] ` <20140307181432.206702017-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
2014-04-17 13:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4807409.VkCA9iV8rJ@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.