From: Timur Tabi <timur@freescale.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] SOC: fix tests in cs4270_hw_params()
Date: Thu, 17 Apr 2008 11:41:12 -0500 [thread overview]
Message-ID: <48077DA8.10809@freescale.com> (raw)
In-Reply-To: <480770A3.3070805@tiscali.nl>
Roel Kluin wrote:
> cs4270_hw_params does several times:
>
> ret = snd_soc_write()
> if (ret < 0)
> ...
>
> This only works when ret is signed.
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Thanks, but in the future, please remember to CC the author of the driver when
posting patches for it.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2008-04-17 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 15:45 [PATCH] SOC: fix tests in cs4270_hw_params() Roel Kluin
2008-04-17 16:09 ` Takashi Iwai
2008-04-17 16:09 ` [alsa-devel] " Takashi Iwai
2008-04-17 16:41 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48077DA8.10809@freescale.com \
--to=timur@freescale.com \
--cc=12o3l@tiscali.nl \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.