From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, shreyansh.jain@nxp.com
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [PATCH] bus/fslmc: update MC to 10.3.x
Date: Fri, 06 Oct 2017 01:34:09 +0200 [thread overview]
Message-ID: <4808052.LEHOq8oruM@xps> (raw)
In-Reply-To: <1505558149-28884-2-git-send-email-hemant.agrawal@nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
This is a huge patch without any comment!
It will be hard to find bugs in it when debugging in future.
And it will be also pointless to reference it in future fixes.
>From a quality point of view, it is bad.
As it is touching only to dpaa2 stuff, it is accepted.
I do not want to be the one digging in it.
Please avoid such patch in future.
Applied
next prev parent reply other threads:[~2017-10-05 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 10:35 [PATCH] NXP DPAA2 bus driver fw upgrade Hemant Agrawal
2017-09-16 10:35 ` [PATCH] bus/fslmc: update MC to 10.3.x Hemant Agrawal
2017-10-05 23:34 ` Thomas Monjalon [this message]
2017-10-06 13:11 ` Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4808052.LEHOq8oruM@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.