All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
To: akpm@linux-foundation.org, sct@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
	jack@suse.cz, sugita <yumiko.sugita.yf@hitachi.com>,
	Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>
Subject: [PATCH 3/4] jbd: abort when failed to log metadata buffers
Date: Fri, 18 Apr 2008 22:38:12 +0900	[thread overview]
Message-ID: <4808A444.1080507@hitachi.com> (raw)
In-Reply-To: <48089B86.5020108@hitachi.com>

Subject: [PATCH 3/4] jbd: abort when failed to log metadata buffers

If we failed to write metadata buffers to the journal space and
succeeded to write the commit record, stale data can be written
back to the filesystem as metadata in the recovery phase.

To avoid this, when we failed to write out metadata buffers,
abort the journal before writing the commit record.

Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
---
 fs/jbd/commit.c |    3 +++
 1 file changed, 3 insertions(+)

Index: linux-2.6.25/fs/jbd/commit.c
===================================================================
--- linux-2.6.25.orig/fs/jbd/commit.c
+++ linux-2.6.25/fs/jbd/commit.c
@@ -716,6 +716,9 @@ wait_for_iobuf:
 		__brelse(bh);
 	}
 
+	if (err)
+		journal_abort(journal, err);
+
 	J_ASSERT (commit_transaction->t_shadow_list == NULL);
 
 	jbd_debug(3, "JBD: commit phase 5\n");

  parent reply	other threads:[~2008-04-18 13:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18 13:00 [PATCH 0/4] jbd: possible filesystem corruption fixes Hidehiro Kawai
2008-04-18 13:36 ` [PATCH 1/4] jbd: strictly check for write errors on data buffers Hidehiro Kawai
2008-04-18 13:37 ` [PATCH 2/4] jbd: ordered data integrity fix Hidehiro Kawai
2008-04-18 13:38 ` Hidehiro Kawai [this message]
2008-04-18 13:39 ` [PATCH 4/4] jbd/ext3: fix error handling for checkpoint io Hidehiro Kawai
2008-04-18 14:09 ` [PATCH 0/4] jbd: possible filesystem corruption fixes Josef Bacik
2008-04-18 19:26   ` Mingming Cao
2008-04-21 21:08     ` Andreas Dilger
2008-04-23 12:45       ` Hidehiro Kawai
2008-04-23 11:01     ` Hidehiro Kawai
2008-04-23 10:59   ` Hidehiro Kawai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4808A444.1080507@hitachi.com \
    --to=hidehiro.kawai.ez@hitachi.com \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satoshi.oshima.fk@hitachi.com \
    --cc=sct@redhat.com \
    --cc=yumiko.sugita.yf@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.