From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Joonwoo Park <joonwpark81@gmail.com>
Cc: kaber@trash.net, jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH 4/5] [E1000]: [VLAN] Turn off the HW vlan filter if promisc
Date: Fri, 18 Apr 2008 10:48:19 -0700 [thread overview]
Message-ID: <4808DEE3.4070203@intel.com> (raw)
In-Reply-To: <b25c3fa70804171854s7b056da1u89e9b758c494a07@mail.gmail.com>
Joonwoo Park wrote:
> 2008/4/18, Kok, Auke <auke-jan.h.kok@intel.com>:
>> My logistical objection against this patch is that it adjusts only one/two drivers
>> to do something, but I don't see anything consistently in all the drivers at all
>> that suggest that this is the right thing to do at all. Either a mandate or
>> something suggesting that all drivers that do vlan filtering *should* do something
>> specific in promiscuous mode.
>
> It's true. We need to fix all the netdev which is VLAN_HW_FILTER capable IMHO.
> However I couldn't make patches for all of them since I don't have those HW :(
sigh, we really should not make e1000(e) guinea pigs - especially at this time.
is there someone who can actually test this for us? I'd be a lot happier if I had
some confidence that people who actually do use promisc/vlans give me a thumbs up.
Auke
prev parent reply other threads:[~2008-04-18 17:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 13:58 [PATCH 4/5] [E1000]: [VLAN] Turn off the HW vlan filter if promisc Joonwoo Park
2008-04-17 21:25 ` Kok, Auke
2008-04-18 1:54 ` Joonwoo Park
2008-04-18 2:08 ` Joonwoo Park
2008-04-18 17:48 ` Kok, Auke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4808DEE3.4070203@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=jeff@garzik.org \
--cc=joonwpark81@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.