From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
Avi Kivity <avi@qumranet.com>,
Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: Re: pv clock: kvm is incompatible with xen :-(
Date: Sat, 19 Apr 2008 08:23:41 +1000 [thread overview]
Message-ID: <48091F6D.7030600@goop.org> (raw)
In-Reply-To: <4808AF8C.5010500@redhat.com>
Gerd Hoffmann wrote:
> I'm looking at the guest side of the issue right now, trying to identify
> common code, and while doing so noticed that xen does the
> version-check-loop in both get_time_values_from_xen(void) and
> xen_clocksource_read(void), and I can't see any obvious reason for that.
> The loop in xen_clocksource_read(void) is not needed IMHO. Can I drop it?
>
No. The get_nsec_offset() needs to be atomic with respect to the
get_time_values() parameters. There could be a loopless
__get_time_values() for use in this case, but given that it almost never
loops, I don't think its worthwhile.
J
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-18 22:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 7:33 pv clock: kvm is incompatible with xen :-( Gerd Hoffmann
2008-04-11 12:06 ` Avi Kivity
2008-04-11 13:44 ` Gerd Hoffmann
2008-04-11 15:01 ` Gerd Hoffmann
2008-04-11 19:02 ` Jeremy Fitzhardinge
2008-04-18 14:26 ` Gerd Hoffmann
2008-04-18 22:23 ` Jeremy Fitzhardinge [this message]
2008-04-21 7:31 ` Gerd Hoffmann
2008-04-21 11:46 ` Jeremy Fitzhardinge
2008-04-21 12:50 ` Gerd Hoffmann
2008-04-21 13:34 ` Jeremy Fitzhardinge
2008-04-21 14:20 ` Gerd Hoffmann
2008-04-22 17:54 ` Glauber Costa
2008-04-23 6:03 ` Gerd Hoffmann
2008-04-24 12:57 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48091F6D.7030600@goop.org \
--to=jeremy@goop.org \
--cc=avi@qumranet.com \
--cc=gcosta@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.