Re: kvm-trace help

["David S. Ahern" <daahern@cisco.com>]

inline.

Liu, Eric E wrote:
> David S. Ahern wrote:
>> I am trying to add a trace marker and the data is coming out all 0's.
>> e.g., 
>>
>> 0 (+       0)  PTE_WRITE     vcpu = 0x00000001  pid = 0x0000240d [
>> gpa = 0x00000000 00000000 gpte = 0x00000000 00000000 ]
>>
>> Patch is attached. I know the data is non-zero as I added an if check
>> before calling the trace to only do the trace if the data is
>> non-zero. Anyone have suggestions on what I am missing?
>>
>> thanks,
>>
>> david
> Hi, david
> 	I read your patch and find this:
> 		+#define KVM_TRC_PTE_WRITE        (KVM_TRC_HANDLER +
> 0x15)
>   		+#define KVM_TRC_PTE_FLOODED      (KVM_TRC_HANDLER +
> 0x16)
>            but in your formats file 
> 		+0x00020015  %(tsc)d (+%(reltsc)8d)  PTE_FLOODED   vcpu
> = 0x%(vcpu)08x  pid = 0x%(pid)08x
> 		+0x00020016  %(tsc)d (+%(reltsc)8d)  PTE_WRITE     vcpu
> = 0x%(vcpu)08x  pid = 0x%(pid)08x [ gpa = 0x%(2)08x %(1)08x gpte =
> 0x%(4)08x %(3)08x ]
> 	You mistake the value, right?
> 

Which value? Do you mean the 0x00020015 and0x00020016?

kvm.h shows KVM_TRC_APIC_ACCESS as KVM_TRC_HANDLER + 0x14. I added the PTE_WRITE
and PTE_FLOODED after that in kvm.h with the values 0x15 and 0x16. Then in the
formats file it shows APIC_ACCESS as 0x00020014, and I added the new PTE entries
after that as 20015 and 20016. The kvmtrace_format tool does show those lines in
its output which makes me believe these values are ok.

What has me puzzled is the 0 values for gpa and gpte. I believe they are not 0
because I added "if (gpa || gpte) before the KVMTRACE_4D(PTE_WRITE, ...) line
and the lines still show up in the trace output.

david

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone