Re: [Qemu-devel] [PATCH] Add -display option

[Anthony Liguori <anthony@codemonkey.ws>]

Sebastian Herbszt wrote:
>> I would better name it -display, as not all computers have 
>> VGA-compatible cards.
>
> --- vl.c.orig Tue Apr 15 20:07:18 2008
> +++ vl.c Sun Apr 20 20:47:15 2008
> @@ -7852,6 +7852,7 @@
>     QEMU_OPTION_old_param,
>     QEMU_OPTION_clock,
>     QEMU_OPTION_startdate,
> +    QEMU_OPTION_display,
> };
>
> typedef struct QEMUOption {
> @@ -7964,6 +7965,7 @@
> #endif
>     { "clock", HAS_ARG, QEMU_OPTION_clock },
>     { "startdate", HAS_ARG, QEMU_OPTION_startdate },
> +    { "display", HAS_ARG, QEMU_OPTION_display },
>     { NULL },
> };
>
> @@ -8816,6 +8818,26 @@
>                         }
>                         rtc_date_offset = time(NULL) - rtc_start_date;
>                     }
> +                }
> +                break;
> +            case QEMU_OPTION_display:
> +                if (!strcmp(optarg, "cirrus")) {
> +                    cirrus_vga_enabled = 1;
> +                    vmsvga_enabled = 0;
> +                } else if (!strcmp(optarg, "std")) {
> +                    cirrus_vga_enabled = 0;
> +                    vmsvga_enabled = 0;
> +                } else if (!strcmp(optarg, "vmware")) {
> +                    cirrus_vga_enabled = 0;
> +                    vmsvga_enabled = 1;
> +                } else if (!strcmp(optarg, "none")) {
> +                    serial_devices[0] = "stdio";
> +                    parallel_devices[0] = "null";
> +                    monitor_device = "stdio";
> +                    nographic = 1;

I don't think -display none should be a synonym for -nographic.  It 
should just suppress the creation of a VGA device.  If a platform 
doesn't support that, it should raise an error.

Regards,

Anthony Liguori

> +                } else {
> +                    fprintf(stderr, "Display devices available: 
> cirrus, std, vmware, none\n");
> +                    exit(1);
>                 }
>                 break;
>             }
>
>
> - Sebastian
>
>
>